Title: [99381] trunk/Tools
- Revision
- 99381
- Author
- [email protected]
- Date
- 2011-11-06 13:01:45 -0800 (Sun, 06 Nov 2011)
Log Message
Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
https://bugs.webkit.org/show_bug.cgi?id=66078
Unreviewed. Add an assert about the type of "args"
to our Executive Mocks and fix a piece of code
from this patch which was hitting that assert
when executing for real.
* Scripts/webkitpy/common/system/executive_mock.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (99380 => 99381)
--- trunk/Tools/ChangeLog 2011-11-06 21:00:21 UTC (rev 99380)
+++ trunk/Tools/ChangeLog 2011-11-06 21:01:45 UTC (rev 99381)
@@ -1,5 +1,18 @@
2011-11-06 Eric Seidel <[email protected]>
+ Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
+ https://bugs.webkit.org/show_bug.cgi?id=66078
+
+ Unreviewed. Add an assert about the type of "args"
+ to our Executive Mocks and fix a piece of code
+ from this patch which was hitting that assert
+ when executing for real.
+
+ * Scripts/webkitpy/common/system/executive_mock.py:
+ * Scripts/webkitpy/layout_tests/port/webkit.py:
+
+2011-11-06 Eric Seidel <[email protected]>
+
Split chunk handling out of prepare_lists_and_print_output to make it more readable
https://bugs.webkit.org/show_bug.cgi?id=71629
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py (99380 => 99381)
--- trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py 2011-11-06 21:00:21 UTC (rev 99380)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py 2011-11-06 21:01:45 UTC (rev 99381)
@@ -59,6 +59,7 @@
return_exit_code=False,
return_stderr=True,
decode_output=False):
+ assert(isinstance(args, list) or isinstance(args, tuple))
if self._should_log:
log("MOCK run_command: %s, cwd=%s" % (args, cwd))
if self._should_throw:
@@ -92,6 +93,7 @@
return_exit_code=False,
return_stderr=True,
decode_output=False):
+ assert(isinstance(args, list) or isinstance(args, tuple))
if self._exception:
raise self._exception
if self._run_command_fn:
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (99380 => 99381)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-11-06 21:00:21 UTC (rev 99380)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-11-06 21:01:45 UTC (rev 99381)
@@ -262,7 +262,7 @@
if not webcore_library_path:
return None
try:
- return self._executive.run_command('nm', webcore_library_path, error_handler=Executive.ignore_error)
+ return self._executive.run_command(['nm', webcore_library_path], error_handler=Executive.ignore_error)
except OSError, e:
_log.warn("Failed to run nm: %s. Can't determine WebCore supported features." % e)
return None
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
