Title: [214689] trunk/Source/WebCore
- Revision
- 214689
- Author
- [email protected]
- Date
- 2017-03-31 15:05:22 -0700 (Fri, 31 Mar 2017)
Log Message
Fix memory leak in CreateSessionDescriptionObserver::OnSuccess
https://bugs.webkit.org/show_bug.cgi?id=170357
Patch by Youenn Fablet <[email protected]> on 2017-03-31
Reviewed by Geoffrey Garen.
No change of behavior.
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::createSessionDescriptionSucceeded): Adopting the raw pointer parameter.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (214688 => 214689)
--- trunk/Source/WebCore/ChangeLog 2017-03-31 22:03:39 UTC (rev 214688)
+++ trunk/Source/WebCore/ChangeLog 2017-03-31 22:05:22 UTC (rev 214689)
@@ -1,3 +1,15 @@
+2017-03-31 Youenn Fablet <[email protected]>
+
+ Fix memory leak in CreateSessionDescriptionObserver::OnSuccess
+ https://bugs.webkit.org/show_bug.cgi?id=170357
+
+ Reviewed by Geoffrey Garen.
+
+ No change of behavior.
+
+ * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+ (WebCore::LibWebRTCMediaEndpoint::createSessionDescriptionSucceeded): Adopting the raw pointer parameter.
+
2017-03-31 Fujii Hironori <[email protected]>
[WinCairo] WebCore::PlatformDisplay::terminateEGLDisplay causes a crash in libGLESv2.dll while processing atexit
Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (214688 => 214689)
--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp 2017-03-31 22:03:39 UTC (rev 214688)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp 2017-03-31 22:05:22 UTC (rev 214689)
@@ -703,8 +703,10 @@
ASSERT_NOT_REACHED();
}
-void LibWebRTCMediaEndpoint::createSessionDescriptionSucceeded(webrtc::SessionDescriptionInterface* description)
+void LibWebRTCMediaEndpoint::createSessionDescriptionSucceeded(webrtc::SessionDescriptionInterface* rawDescription)
{
+ std::unique_ptr<webrtc::SessionDescriptionInterface> description(rawDescription);
+
std::string sdp;
description->ToString(&sdp);
String sdpString(sdp.data(), sdp.size());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
