Title: [214700] trunk/Source/WebCore
Revision
214700
Author
[email protected]
Date
2017-03-31 16:59:20 -0700 (Fri, 31 Mar 2017)

Log Message

Rolling back https://trac.webkit.org/r214689, as it caused many crashes.

Was:
Fix memory leak in CreateSessionDescriptionObserver::OnSuccess
https://bugs.webkit.org/show_bug.cgi?id=170357

* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::createSessionDescriptionSucceeded):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (214699 => 214700)


--- trunk/Source/WebCore/ChangeLog	2017-03-31 23:55:07 UTC (rev 214699)
+++ trunk/Source/WebCore/ChangeLog	2017-03-31 23:59:20 UTC (rev 214700)
@@ -1,3 +1,14 @@
+2017-03-31  Alexey Proskuryakov  <[email protected]>
+
+        Rolling back https://trac.webkit.org/r214689, as it caused many crashes.
+
+        Was:
+        Fix memory leak in CreateSessionDescriptionObserver::OnSuccess
+        https://bugs.webkit.org/show_bug.cgi?id=170357
+
+        * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+        (WebCore::LibWebRTCMediaEndpoint::createSessionDescriptionSucceeded):
+
 2017-03-31  Youenn Fablet  <[email protected]>
 
         Fix memory leak in RealtimeVideoIncomingSource

Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (214699 => 214700)


--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2017-03-31 23:55:07 UTC (rev 214699)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2017-03-31 23:59:20 UTC (rev 214700)
@@ -703,10 +703,8 @@
     ASSERT_NOT_REACHED();
 }
 
-void LibWebRTCMediaEndpoint::createSessionDescriptionSucceeded(webrtc::SessionDescriptionInterface* rawDescription)
+void LibWebRTCMediaEndpoint::createSessionDescriptionSucceeded(webrtc::SessionDescriptionInterface* description)
 {
-    std::unique_ptr<webrtc::SessionDescriptionInterface> description(rawDescription);
-
     std::string sdp;
     description->ToString(&sdp);
     String sdpString(sdp.data(), sdp.size());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to