Title: [214703] trunk/Source/WebCore
- Revision
- 214703
- Author
- [email protected]
- Date
- 2017-03-31 17:11:08 -0700 (Fri, 31 Mar 2017)
Log Message
Rename DOMWindow's m_touchEventListenerCount to m_touchAndGestureEventListenerCount
https://bugs.webkit.org/show_bug.cgi?id=170371
Reviewed by Tim Horton.
This count tracks touch and gesture event listeners, so name it appropriately.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):
* page/DOMWindow.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (214702 => 214703)
--- trunk/Source/WebCore/ChangeLog 2017-04-01 00:10:59 UTC (rev 214702)
+++ trunk/Source/WebCore/ChangeLog 2017-04-01 00:11:08 UTC (rev 214703)
@@ -1,5 +1,20 @@
2017-03-31 Simon Fraser <[email protected]>
+ Rename DOMWindow's m_touchEventListenerCount to m_touchAndGestureEventListenerCount
+ https://bugs.webkit.org/show_bug.cgi?id=170371
+
+ Reviewed by Tim Horton.
+
+ This count tracks touch and gesture event listeners, so name it appropriately.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::addEventListener):
+ (WebCore::DOMWindow::removeEventListener):
+ (WebCore::DOMWindow::removeAllEventListeners):
+ * page/DOMWindow.h:
+
+2017-03-31 Simon Fraser <[email protected]>
+
When destroying a Node, assert that it's been removed from all the touch handler maps
https://bugs.webkit.org/show_bug.cgi?id=170363
rdar://problem/31377469
Modified: trunk/Source/WebCore/page/DOMWindow.cpp (214702 => 214703)
--- trunk/Source/WebCore/page/DOMWindow.cpp 2017-04-01 00:10:59 UTC (rev 214702)
+++ trunk/Source/WebCore/page/DOMWindow.cpp 2017-04-01 00:11:08 UTC (rev 214703)
@@ -1819,11 +1819,11 @@
#endif
#if ENABLE(IOS_TOUCH_EVENTS)
else if (eventNames().isTouchEventType(eventType))
- ++m_touchEventListenerCount;
+ ++m_touchAndGestureEventListenerCount;
#endif
#if ENABLE(IOS_GESTURE_EVENTS)
else if (eventNames().isGestureEventType(eventType))
- ++m_touchEventListenerCount;
+ ++m_touchAndGestureEventListenerCount;
#endif
#if ENABLE(GAMEPAD)
else if (eventNames().isGamepadEventType(eventType))
@@ -1910,14 +1910,14 @@
#endif
#if ENABLE(IOS_TOUCH_EVENTS)
else if (eventNames().isTouchEventType(eventType)) {
- ASSERT(m_touchEventListenerCount > 0);
- --m_touchEventListenerCount;
+ ASSERT(m_touchAndGestureEventListenerCount > 0);
+ --m_touchAndGestureEventListenerCount;
}
#endif
#if ENABLE(IOS_GESTURE_EVENTS)
else if (eventNames().isGestureEventType(eventType)) {
- ASSERT(m_touchEventListenerCount > 0);
- --m_touchEventListenerCount;
+ ASSERT(m_touchAndGestureEventListenerCount > 0);
+ --m_touchAndGestureEventListenerCount;
}
#endif
#if ENABLE(GAMEPAD)
@@ -2023,7 +2023,7 @@
#endif
#if ENABLE(IOS_TOUCH_EVENTS) || ENABLE(IOS_GESTURE_EVENTS)
- m_touchEventListenerCount = 0;
+ m_touchAndGestureEventListenerCount = 0;
#endif
#if ENABLE(TOUCH_EVENTS)
Modified: trunk/Source/WebCore/page/DOMWindow.h (214702 => 214703)
--- trunk/Source/WebCore/page/DOMWindow.h 2017-04-01 00:10:59 UTC (rev 214702)
+++ trunk/Source/WebCore/page/DOMWindow.h 2017-04-01 00:11:08 UTC (rev 214703)
@@ -303,7 +303,7 @@
void resetAllGeolocationPermission();
#if ENABLE(IOS_TOUCH_EVENTS) || ENABLE(IOS_GESTURE_EVENTS)
- bool hasTouchEventListeners() const { return m_touchEventListenerCount > 0; }
+ bool hasTouchOrGestureEventListeners() const { return m_touchAndGestureEventListenerCount > 0; }
#endif
#if ENABLE(USER_MESSAGE_HANDLERS)
@@ -390,7 +390,7 @@
#endif
#if ENABLE(IOS_TOUCH_EVENTS) || ENABLE(IOS_GESTURE_EVENTS)
- unsigned m_touchEventListenerCount { 0 };
+ unsigned m_touchAndGestureEventListenerCount { 0 };
#endif
#if ENABLE(GAMEPAD)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
