Title: [99384] trunk/Source/WebCore
- Revision
- 99384
- Author
- [email protected]
- Date
- 2011-11-06 14:27:34 -0800 (Sun, 06 Nov 2011)
Log Message
Leaks seen in RenderFlowThread::setRegionRangeForBox on Leaks bot
https://bugs.webkit.org/show_bug.cgi?id=71260
Reviewed by Mark Rowe.
Memory leak fix covered by existing tests.
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
Instead of calling remove, call take and then delete, since the
values of the map are owned and need to be deleted when removed.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (99383 => 99384)
--- trunk/Source/WebCore/ChangeLog 2011-11-06 21:31:45 UTC (rev 99383)
+++ trunk/Source/WebCore/ChangeLog 2011-11-06 22:27:34 UTC (rev 99384)
@@ -1,3 +1,17 @@
+2011-11-06 Darin Adler <[email protected]>
+
+ Leaks seen in RenderFlowThread::setRegionRangeForBox on Leaks bot
+ https://bugs.webkit.org/show_bug.cgi?id=71260
+
+ Reviewed by Mark Rowe.
+
+ Memory leak fix covered by existing tests.
+
+ * rendering/RenderFlowThread.cpp:
+ (WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
+ Instead of calling remove, call take and then delete, since the
+ values of the map are owned and need to be deleted when removed.
+
2011-11-06 Adam Barth <[email protected]>
Implement the sandbox directive for CSP
Modified: trunk/Source/WebCore/rendering/RenderFlowThread.cpp (99383 => 99384)
--- trunk/Source/WebCore/rendering/RenderFlowThread.cpp 2011-11-06 21:31:45 UTC (rev 99383)
+++ trunk/Source/WebCore/rendering/RenderFlowThread.cpp 2011-11-06 22:27:34 UTC (rev 99384)
@@ -634,7 +634,7 @@
break;
}
- m_regionRangeMap.remove(box);
+ delete m_regionRangeMap.take(box);
}
bool RenderFlowThread::logicalWidthChangedInRegions(const RenderBlock* block, LayoutUnit offsetFromLogicalTopOfFirstPage)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
