Diff
Modified: trunk/LayoutTests/ChangeLog (99388 => 99389)
--- trunk/LayoutTests/ChangeLog 2011-11-07 00:42:21 UTC (rev 99388)
+++ trunk/LayoutTests/ChangeLog 2011-11-07 02:07:50 UTC (rev 99389)
@@ -1,3 +1,17 @@
+2011-11-06 Dominic Cooney <[email protected]>
+
+ Remove initBeforeLoadEvent method
+ https://bugs.webkit.org/show_bug.cgi?id=71636
+
+ Reviewed by Adam Barth.
+
+ * fast/dom/Window/window-properties-expected.txt:
+ * platform/gtk/fast/dom/Window/window-properties-expected.txt:
+ * platform/mac/fast/dom/Window/window-properties-expected.txt:
+ * platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
+ * platform/qt/fast/dom/Window/window-properties-expected.txt:
+ * platform/win/fast/dom/Window/window-properties-expected.txt:
+
2011-11-06 Ryosuke Niwa <[email protected]>
Skip tests for autocorrection panel on Chromium port since
Modified: trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt (99388 => 99389)
--- trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt 2011-11-07 00:42:21 UTC (rev 99388)
+++ trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt 2011-11-07 02:07:50 UTC (rev 99389)
@@ -147,7 +147,6 @@
window.BeforeLoadEvent.prototype.MOUSEOVER [number]
window.BeforeLoadEvent.prototype.MOUSEUP [number]
window.BeforeLoadEvent.prototype.SELECT [number]
-window.BeforeLoadEvent.prototype.initBeforeLoadEvent [function]
window.BeforeLoadEvent.prototype.initEvent [function]
window.BeforeLoadEvent.prototype.preventDefault [function]
window.BeforeLoadEvent.prototype.stopImmediatePropagation [function]
Modified: trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt (99388 => 99389)
--- trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt 2011-11-07 00:42:21 UTC (rev 99388)
+++ trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt 2011-11-07 02:07:50 UTC (rev 99389)
@@ -147,7 +147,6 @@
window.BeforeLoadEvent.prototype.MOUSEOVER [number]
window.BeforeLoadEvent.prototype.MOUSEUP [number]
window.BeforeLoadEvent.prototype.SELECT [number]
-window.BeforeLoadEvent.prototype.initBeforeLoadEvent [function]
window.BeforeLoadEvent.prototype.initEvent [function]
window.BeforeLoadEvent.prototype.preventDefault [function]
window.BeforeLoadEvent.prototype.stopImmediatePropagation [function]
Modified: trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt (99388 => 99389)
--- trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt 2011-11-07 00:42:21 UTC (rev 99388)
+++ trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt 2011-11-07 02:07:50 UTC (rev 99389)
@@ -172,7 +172,6 @@
window.BeforeLoadEvent.prototype.MOUSEOVER [number]
window.BeforeLoadEvent.prototype.MOUSEUP [number]
window.BeforeLoadEvent.prototype.SELECT [number]
-window.BeforeLoadEvent.prototype.initBeforeLoadEvent [function]
window.BeforeLoadEvent.prototype.initEvent [function]
window.BeforeLoadEvent.prototype.preventDefault [function]
window.BeforeLoadEvent.prototype.stopImmediatePropagation [function]
Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt (99388 => 99389)
--- trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-11-07 00:42:21 UTC (rev 99388)
+++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-11-07 02:07:50 UTC (rev 99389)
@@ -145,7 +145,6 @@
window.BeforeLoadEvent.prototype.MOUSEOVER [number]
window.BeforeLoadEvent.prototype.MOUSEUP [number]
window.BeforeLoadEvent.prototype.SELECT [number]
-window.BeforeLoadEvent.prototype.initBeforeLoadEvent [function]
window.BeforeLoadEvent.prototype.initEvent [function]
window.BeforeLoadEvent.prototype.preventDefault [function]
window.BeforeLoadEvent.prototype.stopImmediatePropagation [function]
Modified: trunk/LayoutTests/platform/qt-wk2/fast/dom/Window/window-properties-expected.txt (99388 => 99389)
--- trunk/LayoutTests/platform/qt-wk2/fast/dom/Window/window-properties-expected.txt 2011-11-07 00:42:21 UTC (rev 99388)
+++ trunk/LayoutTests/platform/qt-wk2/fast/dom/Window/window-properties-expected.txt 2011-11-07 02:07:50 UTC (rev 99389)
@@ -145,7 +145,6 @@
window.BeforeLoadEvent.prototype.MOUSEOVER [number]
window.BeforeLoadEvent.prototype.MOUSEUP [number]
window.BeforeLoadEvent.prototype.SELECT [number]
-window.BeforeLoadEvent.prototype.initBeforeLoadEvent [function]
window.BeforeLoadEvent.prototype.initEvent [function]
window.BeforeLoadEvent.prototype.preventDefault [function]
window.BeforeLoadEvent.prototype.stopImmediatePropagation [function]
Modified: trunk/LayoutTests/platform/win/fast/dom/Window/window-properties-expected.txt (99388 => 99389)
--- trunk/LayoutTests/platform/win/fast/dom/Window/window-properties-expected.txt 2011-11-07 00:42:21 UTC (rev 99388)
+++ trunk/LayoutTests/platform/win/fast/dom/Window/window-properties-expected.txt 2011-11-07 02:07:50 UTC (rev 99389)
@@ -147,7 +147,6 @@
window.BeforeLoadEvent.prototype.MOUSEOVER [number]
window.BeforeLoadEvent.prototype.MOUSEUP [number]
window.BeforeLoadEvent.prototype.SELECT [number]
-window.BeforeLoadEvent.prototype.initBeforeLoadEvent [function]
window.BeforeLoadEvent.prototype.initEvent [function]
window.BeforeLoadEvent.prototype.preventDefault [function]
window.BeforeLoadEvent.prototype.stopImmediatePropagation [function]
Modified: trunk/Source/WebCore/ChangeLog (99388 => 99389)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 00:42:21 UTC (rev 99388)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 02:07:50 UTC (rev 99389)
@@ -1,3 +1,15 @@
+2011-11-06 Dominic Cooney <[email protected]>
+
+ Remove initBeforeLoadEvent method
+ https://bugs.webkit.org/show_bug.cgi?id=71636
+
+ Reviewed by Adam Barth.
+
+ Test: fast/dom/Window/window-properties.html
+
+ * dom/BeforeLoadEvent.h:
+ * dom/BeforeLoadEvent.idl:
+
2011-11-06 Adam Barth <[email protected]>
Don't crash when a context hasn't been created. This fixed a
Modified: trunk/Source/WebCore/dom/BeforeLoadEvent.h (99388 => 99389)
--- trunk/Source/WebCore/dom/BeforeLoadEvent.h 2011-11-07 00:42:21 UTC (rev 99388)
+++ trunk/Source/WebCore/dom/BeforeLoadEvent.h 2011-11-07 02:07:50 UTC (rev 99389)
@@ -57,16 +57,6 @@
return adoptRef(new BeforeLoadEvent(type, initializer));
}
- void initBeforeLoadEvent(const AtomicString& type, bool canBubble, bool cancelable, const String& url)
- {
- if (dispatched())
- return;
-
- initEvent(type, canBubble, cancelable);
-
- m_url = url;
- }
-
const String& url() const { return m_url; }
virtual const AtomicString& interfaceName() const { return eventNames().interfaceForBeforeLoadEvent; }
Modified: trunk/Source/WebCore/dom/BeforeLoadEvent.idl (99388 => 99389)
--- trunk/Source/WebCore/dom/BeforeLoadEvent.idl 2011-11-07 00:42:21 UTC (rev 99388)
+++ trunk/Source/WebCore/dom/BeforeLoadEvent.idl 2011-11-07 02:07:50 UTC (rev 99389)
@@ -30,10 +30,6 @@
CanBeConstructed,
CustomConstructor
] BeforeLoadEvent : Event {
- void initBeforeLoadEvent(in [Optional=CallWithDefaultValue] DOMString type,
- in [Optional=CallWithDefaultValue] boolean canBubble,
- in [Optional=CallWithDefaultValue] boolean cancelable,
- in [Optional=CallWithDefaultValue] DOMString url);
readonly attribute DOMString url;
};
