Title: [99391] trunk/Source/WebCore
- Revision
- 99391
- Author
- [email protected]
- Date
- 2011-11-06 18:34:40 -0800 (Sun, 06 Nov 2011)
Log Message
Remove ColorInputType::handleClickEvent
https://bugs.webkit.org/show_bug.cgi?id=71640
Reviewed by Kent Tamura.
When you click the input color element, both ColorInputType::handleClickEvent and
ColorInputType::handleDOMActivateEvent are called, causing Chrome::openColorChooser
to be called too many times.
* html/ColorInputType.cpp: Removed ColorInputType::handleClickEvent
* html/ColorInputType.h: Removed ColorInputType::handleClickEvent
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (99390 => 99391)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 02:25:46 UTC (rev 99390)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 02:34:40 UTC (rev 99391)
@@ -1,5 +1,19 @@
2011-11-06 Keishi Hattori <[email protected]>
+ Remove ColorInputType::handleClickEvent
+ https://bugs.webkit.org/show_bug.cgi?id=71640
+
+ Reviewed by Kent Tamura.
+
+ When you click the input color element, both ColorInputType::handleClickEvent and
+ ColorInputType::handleDOMActivateEvent are called, causing Chrome::openColorChooser
+ to be called too many times.
+
+ * html/ColorInputType.cpp: Removed ColorInputType::handleClickEvent
+ * html/ColorInputType.h: Removed ColorInputType::handleClickEvent
+
+2011-11-06 Keishi Hattori <[email protected]>
+
Remove extra semicolon in ColorInputType
https://bugs.webkit.org/show_bug.cgi?id=71639
Modified: trunk/Source/WebCore/html/ColorInputType.cpp (99390 => 99391)
--- trunk/Source/WebCore/html/ColorInputType.cpp 2011-11-07 02:25:46 UTC (rev 99390)
+++ trunk/Source/WebCore/html/ColorInputType.cpp 2011-11-07 02:34:40 UTC (rev 99391)
@@ -132,21 +132,6 @@
}
}
-void ColorInputType::handleClickEvent(MouseEvent* event)
-{
- if (event->isSimulated())
- return;
-
- if (element()->disabled() || element()->readOnly())
- return;
-
- if (Chrome* chrome = this->chrome()) {
- ColorChooser::chooser()->connectClient(this);
- chrome->openColorChooser(ColorChooser::chooser(), valueAsColor());
- }
- event->setDefaultHandled();
-}
-
void ColorInputType::handleDOMActivateEvent(Event* event)
{
if (element()->disabled() || element()->readOnly() || !element()->renderer())
Modified: trunk/Source/WebCore/html/ColorInputType.h (99390 => 99391)
--- trunk/Source/WebCore/html/ColorInputType.h 2011-11-07 02:25:46 UTC (rev 99390)
+++ trunk/Source/WebCore/html/ColorInputType.h 2011-11-07 02:34:40 UTC (rev 99391)
@@ -53,7 +53,6 @@
virtual Color valueAsColor() const;
virtual void createShadowSubtree();
virtual void setValue(const String&, bool valueChanged, bool sendChangeEvent);
- virtual void handleClickEvent(MouseEvent*);
virtual void handleDOMActivateEvent(Event*);
virtual void detach();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
