Title: [214853] trunk/Source/WebInspectorUI
- Revision
- 214853
- Author
- nvasil...@apple.com
- Date
- 2017-04-03 16:11:25 -0700 (Mon, 03 Apr 2017)
Log Message
Web Inspector: WebSockets: Don't store binary frames in memory since they are never shown
https://bugs.webkit.org/show_bug.cgi?id=169649
<rdar://problem/31053069>
Reviewed by Brian Burg.
* UserInterface/Models/WebSocketResource.js:
(WebInspector.WebSocketResource.prototype.addFrame):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (214852 => 214853)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-04-03 23:08:42 UTC (rev 214852)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-04-03 23:11:25 UTC (rev 214853)
@@ -1,3 +1,14 @@
+2017-04-03 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: WebSockets: Don't store binary frames in memory since they are never shown
+ https://bugs.webkit.org/show_bug.cgi?id=169649
+ <rdar://problem/31053069>
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Models/WebSocketResource.js:
+ (WebInspector.WebSocketResource.prototype.addFrame):
+
2017-04-03 Devin Rousso <web...@devinrousso.com>
Web Inspector: Preference for Auto Showing Scope Chain sidebar on pause
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/WebSocketResource.js (214852 => 214853)
--- trunk/Source/WebInspectorUI/UserInterface/Models/WebSocketResource.js 2017-04-03 23:08:42 UTC (rev 214852)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/WebSocketResource.js 2017-04-03 23:11:25 UTC (rev 214853)
@@ -61,7 +61,15 @@
addFrame(data, isOutgoing, opcode, timestamp, elapsedTime)
{
- let frame = {data, isOutgoing, opcode, walltime: this._walltimeForWebSocketTimestamp(timestamp)};
+ let frameData;
+
+ // Binary data is never shown in the UI, don't clog memory with it.
+ if (opcode === WebInspector.WebSocketResource.OpCodes.BinaryFrame)
+ frameData = null;
+ else
+ frameData = data;
+
+ let frame = {data: frameData, isOutgoing, opcode, walltime: this._walltimeForWebSocketTimestamp(timestamp)};
this._frames.push(frame);
this.increaseSize(data.length, elapsedTime);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
