Title: [99411] trunk
Revision
99411
Author
[email protected]
Date
2011-11-07 05:43:17 -0800 (Mon, 07 Nov 2011)

Log Message

Web Inspector: use toString as the Date object description.
https://bugs.webkit.org/show_bug.cgi?id=71605

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/remote-object.html

* inspector/InjectedScriptSource.js:
(.):

LayoutTests:

* inspector/remote-object-expected.txt: Added.
* inspector/remote-object.html: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (99410 => 99411)


--- trunk/LayoutTests/ChangeLog	2011-11-07 13:40:40 UTC (rev 99410)
+++ trunk/LayoutTests/ChangeLog	2011-11-07 13:43:17 UTC (rev 99411)
@@ -1,3 +1,13 @@
+2011-11-07  Andrey Kosyakov  <[email protected]>
+
+        Web Inspector: use toString as the Date object description.
+        https://bugs.webkit.org/show_bug.cgi?id=71605
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/remote-object-expected.txt: Added.
+        * inspector/remote-object.html: Added.
+
 2011-11-07  Philippe Normand  <[email protected]>
 
         Unreviewed, GTK flaky tests clean-up. Moved most of them to

Added: trunk/LayoutTests/inspector/remote-object-expected.txt (0 => 99411)


--- trunk/LayoutTests/inspector/remote-object-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/inspector/remote-object-expected.txt	2011-11-07 13:43:17 UTC (rev 99411)
@@ -0,0 +1,4 @@
+Tests formatting of different types of remote objects.
+
+date = Wed Dec 07 2011 12:01:00 
+
Property changes on: trunk/LayoutTests/inspector/remote-object-expected.txt
___________________________________________________________________

Added: svn:eol-style

Added: trunk/LayoutTests/inspector/remote-object.html (0 => 99411)


--- trunk/LayoutTests/inspector/remote-object.html	                        (rev 0)
+++ trunk/LayoutTests/inspector/remote-object.html	2011-11-07 13:43:17 UTC (rev 99411)
@@ -0,0 +1,25 @@
+<html>
+<head>
+<script src=""
+<script>
+
+function test()
+{
+    function callback(result)
+    {
+        InspectorTest.addResult("date = " + result.description.substring(0, 25));
+        InspectorTest.completeTest();
+    }
+    InspectorTest.evaluateInPage("new Date(2011, 11, 7, 12, 01)", callback);
+}
+
+</script>
+</head>
+
+<body _onload_="runTest()">
+<p>
+Tests formatting of different types of remote objects.
+</p>
+
+</body>
+</html>
Property changes on: trunk/LayoutTests/inspector/remote-object.html
___________________________________________________________________

Added: svn:eol-style

Modified: trunk/Source/WebCore/ChangeLog (99410 => 99411)


--- trunk/Source/WebCore/ChangeLog	2011-11-07 13:40:40 UTC (rev 99410)
+++ trunk/Source/WebCore/ChangeLog	2011-11-07 13:43:17 UTC (rev 99411)
@@ -1,3 +1,15 @@
+2011-11-07  Andrey Kosyakov  <[email protected]>
+
+        Web Inspector: use toString as the Date object description.
+        https://bugs.webkit.org/show_bug.cgi?id=71605
+
+        Reviewed by Yury Semikhatsky.
+
+        Test: inspector/remote-object.html
+
+        * inspector/InjectedScriptSource.js:
+        (.):
+
 2011-10-26  Andrey Kosyakov  <[email protected]>
 
         Web Inspector: [refactoring] get JS-specific methods out of SourceFrame

Modified: trunk/Source/WebCore/inspector/InjectedScriptSource.js (99410 => 99411)


--- trunk/Source/WebCore/inspector/InjectedScriptSource.js	2011-11-07 13:40:40 UTC (rev 99410)
+++ trunk/Source/WebCore/inspector/InjectedScriptSource.js	2011-11-07 13:43:17 UTC (rev 99411)
@@ -430,6 +430,9 @@
         if (subtype === "regexp")
             return this._toString(obj);
 
+        if (subtype === "date")
+            return this._toString(obj);
+
         var className = InjectedScriptHost.internalConstructorName(obj);
         if (subtype === "array") {
             if (typeof obj.length === "number")
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to