Title: [214963] trunk
- Revision
- 214963
- Author
- [email protected]
- Date
- 2017-04-05 13:15:04 -0700 (Wed, 05 Apr 2017)
Log Message
Unreviewed, rolling out r214962.
Roll r214937 back in because it wasn't at fault for the build
breakage.
Reverted changeset:
"Unreviewed, rolling out r214937."
https://bugs.webkit.org/show_bug.cgi?id=170365
http://trac.webkit.org/changeset/214962
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (214962 => 214963)
--- trunk/Source/WebCore/ChangeLog 2017-04-05 19:43:04 UTC (rev 214962)
+++ trunk/Source/WebCore/ChangeLog 2017-04-05 20:15:04 UTC (rev 214963)
@@ -1,5 +1,18 @@
2017-04-05 Ryan Haddad <[email protected]>
+ Unreviewed, rolling out r214962.
+
+ Roll r214937 back in because it wasn't at fault for the build
+ breakage.
+
+ Reverted changeset:
+
+ "Unreviewed, rolling out r214937."
+ https://bugs.webkit.org/show_bug.cgi?id=170365
+ http://trac.webkit.org/changeset/214962
+
+2017-04-05 Ryan Haddad <[email protected]>
+
Unreviewed, rolling out r214937.
This change broke an internal build.
Modified: trunk/Source/WebCore/editing/cocoa/DataDetection.mm (214962 => 214963)
--- trunk/Source/WebCore/editing/cocoa/DataDetection.mm 2017-04-05 19:43:04 UTC (rev 214962)
+++ trunk/Source/WebCore/editing/cocoa/DataDetection.mm 2017-04-05 20:15:04 UTC (rev 214963)
@@ -274,7 +274,7 @@
static bool searchForLinkRemovingExistingDDLinks(Node& startNode, Node& endNode, bool& didModifyDOM)
{
didModifyDOM = false;
- for (Node* node = &startNode; node; node = NodeTraversal::next(*node, &startNode)) {
+ for (Node* node = &startNode; node; node = NodeTraversal::next(*node)) {
if (is<HTMLAnchorElement>(*node)) {
auto& anchor = downcast<HTMLAnchorElement>(*node);
if (!equalIgnoringASCIICase(anchor.attributeWithoutSynchronization(x_apple_data_detectorsAttr), "true"))
Modified: trunk/Tools/ChangeLog (214962 => 214963)
--- trunk/Tools/ChangeLog 2017-04-05 19:43:04 UTC (rev 214962)
+++ trunk/Tools/ChangeLog 2017-04-05 20:15:04 UTC (rev 214963)
@@ -1,5 +1,18 @@
2017-04-05 Ryan Haddad <[email protected]>
+ Unreviewed, rolling out r214962.
+
+ Roll r214937 back in because it wasn't at fault for the build
+ breakage.
+
+ Reverted changeset:
+
+ "Unreviewed, rolling out r214937."
+ https://bugs.webkit.org/show_bug.cgi?id=170365
+ http://trac.webkit.org/changeset/214962
+
+2017-04-05 Ryan Haddad <[email protected]>
+
Unreviewed, rolling out r214937.
This change broke an internal build.
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm (214962 => 214963)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm 2017-04-05 19:43:04 UTC (rev 214962)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm 2017-04-05 20:15:04 UTC (rev 214963)
@@ -60,7 +60,7 @@
[webView loadHTMLString:HTMLString baseURL:nil];
[webView _test_waitForDidFinishNavigation];
- [webView evaluateJavaScript:@"document.getElementsByTagName('a').length" completionHandler:^(id value, NSError *error) {
+ [webView evaluateJavaScript:@"document.querySelectorAll('a[x-apple-data-detectors=true]').length" completionHandler:^(id value, NSError *error) {
EXPECT_EQ(linkCount, [value unsignedIntValue]);
ranScript = true;
}];
@@ -81,7 +81,10 @@
expectLinkCount(webView.get(), @"tomorrow at 6PM", 1);
expectLinkCount(webView.get(), @"yesterday at 6PM", 0);
+ expectLinkCount(webView.get(), @"<a href=''>tomorrow at 6PM</a>", 0);
+ expectLinkCount(webView.get(), @"<a href=''>tomorrow</a> at <a href=''>6PM</a>", 0);
+
NSTimeInterval week = 60 * 60 * 24 * 7;
[UIDelegate setReferenceDate:[NSDate dateWithTimeIntervalSinceNow:-week]];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
