Title: [214967] trunk/Source/WebInspectorUI
- Revision
- 214967
- Author
- [email protected]
- Date
- 2017-04-05 13:58:50 -0700 (Wed, 05 Apr 2017)
Log Message
Web Inspector: Probe values not showing in sidebar
https://bugs.webkit.org/show_bug.cgi?id=170143
Reviewed by Joseph Pecoraro.
Force the DataGrid to refresh its layout after adding a probe sample.
* UserInterface/Views/ProbeSetDataGrid.css:
(.details-section.probe-set .data-grid tr.data-updated):
(.details-section.probe-set .data-grid > tr.data-updated): Deleted.
Drive-by fix: selector didn't match any rows.
* UserInterface/Views/ProbeSetDataGrid.js:
(WebInspector.ProbeSetDataGrid.prototype._updateNodeForFrame):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (214966 => 214967)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-04-05 20:44:10 UTC (rev 214966)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-04-05 20:58:50 UTC (rev 214967)
@@ -1,5 +1,22 @@
2017-04-05 Matt Baker <[email protected]>
+ Web Inspector: Probe values not showing in sidebar
+ https://bugs.webkit.org/show_bug.cgi?id=170143
+
+ Reviewed by Joseph Pecoraro.
+
+ Force the DataGrid to refresh its layout after adding a probe sample.
+
+ * UserInterface/Views/ProbeSetDataGrid.css:
+ (.details-section.probe-set .data-grid tr.data-updated):
+ (.details-section.probe-set .data-grid > tr.data-updated): Deleted.
+ Drive-by fix: selector didn't match any rows.
+
+ * UserInterface/Views/ProbeSetDataGrid.js:
+ (WebInspector.ProbeSetDataGrid.prototype._updateNodeForFrame):
+
+2017-04-05 Matt Baker <[email protected]>
+
Web Inspector: XHR breakpoints should be global
https://bugs.webkit.org/show_bug.cgi?id=170033
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.css (214966 => 214967)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.css 2017-04-05 20:44:10 UTC (rev 214966)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.css 2017-04-05 20:58:50 UTC (rev 214967)
@@ -59,7 +59,7 @@
border-bottom: 2px solid hsl(0, 0%, 40%);
}
-.details-section.probe-set .data-grid > tr.data-updated {
+.details-section.probe-set .data-grid tr.data-updated {
animation-duration: 0.3s;
animation-name: blink-probe-frame;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js (214966 => 214967)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js 2017-04-05 20:44:10 UTC (rev 214966)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js 2017-04-05 20:58:50 UTC (rev 214967)
@@ -135,6 +135,9 @@
}
console.assert(node);
+ // FIXME: <https://webkit.org/b/152269> Web Inspector: Convert DetailsSection classes to use View
+ this.updateLayoutIfNeeded();
+
node.element.classList.add("data-updated");
window.setTimeout(function() {
node.element.classList.remove("data-updated");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
