Skip to site navigation (Press enter)

[webkit-changes] [214985] trunk

commit-queue Wed, 05 Apr 2017 21:43:03 -0700

Title: [214985] trunk

Revision: 214985
Author: [email protected]
Date: 2017-04-05 21:42:33 -0700 (Wed, 05 Apr 2017)

Log Message

test262: module test progressions need updated expectations (@@iterator changes)
https://bugs.webkit.org/show_bug.cgi?id=170535


Patch by Joseph Pecoraro <[email protected]> on 2017-04-05
Reviewed by Saam Barati.

JSTests:

* test262.yaml:
After r212430 the tests are out of date and are now expected to fail.

Tools:

* Scripts/run-jsc-stress-tests:
Add :failDueToOutdatedOrBadTest to distinguish between a test failure
in _javascript_Core or an outdated or incorrect test262 test.

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/test262.yaml
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests

Diff

Modified: trunk/JSTests/ChangeLog (214984 => 214985)


--- trunk/JSTests/ChangeLog	2017-04-06 04:42:28 UTC (rev 214984)
+++ trunk/JSTests/ChangeLog	2017-04-06 04:42:33 UTC (rev 214985)
@@ -1,3 +1,13 @@
+2017-04-05  Joseph Pecoraro  <[email protected]>
+
+        test262: module test progressions need updated expectations (@@iterator changes)
+        https://bugs.webkit.org/show_bug.cgi?id=170535
+
+        Reviewed by Saam Barati.
+
+        * test262.yaml:
+        After r212430 the tests are out of date and are now expected to fail.
+
 2017-04-05  Michael Saboff  <[email protected]>
 
         Unreviewed rollout of r214642 as the test still intermittently fails.

Modified: trunk/JSTests/test262.yaml (214984 => 214985)


--- trunk/JSTests/test262.yaml	2017-04-06 04:42:28 UTC (rev 214984)
+++ trunk/JSTests/test262.yaml	2017-04-06 04:42:33 UTC (rev 214985)
@@ -71908,27 +71908,27 @@
 - path: test262/test/language/module-code/instn-uniq-env-rec.js
   cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/Symbol.iterator/length.js
-  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
+  cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
 - path: test262/test/language/module-code/namespace/Symbol.iterator/list-iter-next-length.js
-  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
+  cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
 - path: test262/test/language/module-code/namespace/Symbol.iterator/list-iter-next-name.js
-  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
+  cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
 - path: test262/test/language/module-code/namespace/Symbol.iterator/list-iter-next-prop-desc.js
-  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
+  cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
 - path: test262/test/language/module-code/namespace/Symbol.iterator/name.js
-  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
+  cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js", "../../../../../harness/propertyHelper.js"], [:module]
 - path: test262/test/language/module-code/namespace/Symbol.iterator/prop-desc.js
-  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
+  cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/Symbol.iterator/this-val-not-ns.js
-  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
+  cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/Symbol.iterator/values-binding-types.js
-  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
+  cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/Symbol.iterator/values-binding-types_.js
   cmd: prepareTest262Fixture
 - path: test262/test/language/module-code/namespace/Symbol.iterator/values-order.js
-  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
+  cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/Symbol.toStringTag.js
-  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:module]
+  cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/internals/define-own-property.js
   cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/internals/delete-exported-init.js
@@ -71936,7 +71936,7 @@
 - path: test262/test/language/module-code/namespace/internals/delete-exported-uninit.js
   cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/internals/delete-non-exported.js
-  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
+  cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/internals/get-own-property-str-found-init.js
   cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/internals/get-own-property-str-found-uninit.js
@@ -71944,7 +71944,7 @@
 - path: test262/test/language/module-code/namespace/internals/get-own-property-str-not-found.js
   cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/internals/get-own-property-sym.js
-  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
+  cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/internals/get-prototype-of.js
   cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/internals/get-str-found-init.js
@@ -71958,7 +71958,7 @@
 - path: test262/test/language/module-code/namespace/internals/get-str-update.js
   cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/internals/get-sym-found.js
-  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
+  cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/internals/get-sym-not-found.js
   cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/internals/has-property-str-found-init.js
@@ -71968,17 +71968,17 @@
 - path: test262/test/language/module-code/namespace/internals/has-property-str-not-found.js
   cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/internals/has-property-sym-found.js
-  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
+  cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/internals/has-property-sym-not-found.js
   cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/internals/is-extensible.js
   cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/internals/own-property-keys-binding-types.js
-  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
+  cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/internals/own-property-keys-binding-types_FIXTURE.js
   cmd: prepareTest262Fixture
 - path: test262/test/language/module-code/namespace/internals/own-property-keys-sort.js
-  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
+  cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/internals/prevent-extensions.js
   cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:module]
 - path: test262/test/language/module-code/namespace/internals/set-prototype-of.js

Modified: trunk/Tools/ChangeLog (214984 => 214985)


--- trunk/Tools/ChangeLog	2017-04-06 04:42:28 UTC (rev 214984)
+++ trunk/Tools/ChangeLog	2017-04-06 04:42:33 UTC (rev 214985)
@@ -1,5 +1,16 @@
 2017-04-05  Joseph Pecoraro  <[email protected]>
 
+        test262: module test progressions need updated expectations (@@iterator changes)
+        https://bugs.webkit.org/show_bug.cgi?id=170535
+
+        Reviewed by Saam Barati.
+
+        * Scripts/run-jsc-stress-tests:
+        Add :failDueToOutdatedOrBadTest to distinguish between a test failure
+        in _javascript_Core or an outdated or incorrect test262 test.
+
+2017-04-05  Joseph Pecoraro  <[email protected]>
+
         Remove run-jsc-stress-tests benign warning about otool '-S' switch
         https://bugs.webkit.org/show_bug.cgi?id=170527

Modified: trunk/Tools/Scripts/run-jsc-stress-tests (214984 => 214985)


--- trunk/Tools/Scripts/run-jsc-stress-tests	2017-04-06 04:42:28 UTC (rev 214984)
+++ trunk/Tools/Scripts/run-jsc-stress-tests	2017-04-06 04:42:33 UTC (rev 214985)
@@ -1128,6 +1128,9 @@
     when :fail
         errorHandler = expectedFailErrorHandler
         outputHandler = noisyOutputHandler
+    when :failDueToOutdatedOrBadTest
+        errorHandler = expectedFailErrorHandler
+        outputHandler = noisyOutputHandler
     else
         raise "Invalid mode: #{mode}"
     end

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes