Title: [215001] trunk
Revision
215001
Author
nael.ouedra...@crf.canon.fr
Date
2017-04-06 01:24:30 -0700 (Thu, 06 Apr 2017)

Log Message

[GTK] Build fails when using icecream, ccache and cmake 3.6
https://bugs.webkit.org/show_bug.cgi?id=170498

Reviewed by Michael Catanzaro.

Disable ninja response file when using icecream, ccache and cmake > 3.5.

* Source/cmake/OptionsCommon.cmake:

Modified Paths

Diff

Modified: trunk/ChangeLog (215000 => 215001)


--- trunk/ChangeLog	2017-04-06 08:23:15 UTC (rev 215000)
+++ trunk/ChangeLog	2017-04-06 08:24:30 UTC (rev 215001)
@@ -1,3 +1,14 @@
+2017-04-06  Nael Ouedraogo  <nael.ouedra...@crf.canon.fr>
+
+        [GTK] Build fails when using icecream, ccache and cmake 3.6
+        https://bugs.webkit.org/show_bug.cgi?id=170498
+
+        Reviewed by Michael Catanzaro.
+
+        Disable ninja response file when using icecream, ccache and cmake > 3.5.
+
+        * Source/cmake/OptionsCommon.cmake:
+
 2017-04-04  Ross Kirsling  <ross.kirsl...@sony.com>
 
         [CMake] Enforce Python 2

Modified: trunk/Source/cmake/OptionsCommon.cmake (215000 => 215001)


--- trunk/Source/cmake/OptionsCommon.cmake	2017-04-06 08:23:15 UTC (rev 215000)
+++ trunk/Source/cmake/OptionsCommon.cmake	2017-04-06 08:24:30 UTC (rev 215001)
@@ -215,8 +215,8 @@
 if (NOT APPLE)
    # If using Ninja with cmake >= 3.6.0 and icecream, then the build is broken
    # if enable the response files. See https://bugs.webkit.org/show_bug.cgi?id=168770
-   if (NOT ((${CMAKE_CXX_COMPILER} MATCHES ".*icecc.*") AND (CMAKE_GENERATOR STREQUAL "Ninja") AND (${CMAKE_VERSION} VERSION_GREATER 3.5)))
-      set(CMAKE_NINJA_FORCE_RESPONSE_FILE 1)
+   if (NOT ((((${CMAKE_CXX_COMPILER} MATCHES ".*ccache.*") AND ($ENV{CCACHE_PREFIX} MATCHES ".*icecc.*")) OR (${CMAKE_CXX_COMPILER} MATCHES ".*icecc.*")) AND (CMAKE_GENERATOR STREQUAL "Ninja") AND (${CMAKE_VERSION} VERSION_GREATER 3.5)))
+       set(CMAKE_NINJA_FORCE_RESPONSE_FILE 1)
    endif ()
 endif ()
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to