Title: [215113] trunk/Source/WebInspectorUI
- Revision
- 215113
- Author
- mattba...@apple.com
- Date
- 2017-04-07 12:31:06 -0700 (Fri, 07 Apr 2017)
Log Message
Web Inspector: DOM/XHR breakpoint tree elements shouldn't persist their represented objects
https://bugs.webkit.org/show_bug.cgi?id=170611
<rdar://problem/31506161>
Reviewed by Joseph Pecoraro.
Prevent tree elements for DOM and XHR breakpoints from persisting their
represented objects.
* UserInterface/Views/ContentView.js:
(WebInspector.ContentView.createFromRepresentedObject):
* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype._isTreeElementWithoutRepresentedObject):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (215112 => 215113)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-04-07 19:28:09 UTC (rev 215112)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-04-07 19:31:06 UTC (rev 215113)
@@ -1,3 +1,19 @@
+2017-04-07 Matt Baker <mattba...@apple.com>
+
+ Web Inspector: DOM/XHR breakpoint tree elements shouldn't persist their represented objects
+ https://bugs.webkit.org/show_bug.cgi?id=170611
+ <rdar://problem/31506161>
+
+ Reviewed by Joseph Pecoraro.
+
+ Prevent tree elements for DOM and XHR breakpoints from persisting their
+ represented objects.
+
+ * UserInterface/Views/ContentView.js:
+ (WebInspector.ContentView.createFromRepresentedObject):
+ * UserInterface/Views/NavigationSidebarPanel.js:
+ (WebInspector.NavigationSidebarPanel.prototype._isTreeElementWithoutRepresentedObject):
+
2017-04-06 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: Source Map Resources should show up in the Debugger Sources list
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js (215112 => 215113)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js 2017-04-07 19:28:09 UTC (rev 215112)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js 2017-04-07 19:31:06 UTC (rev 215113)
@@ -121,14 +121,6 @@
}
}
- if (representedObject instanceof WebInspector.DOMBreakpoint) {
- if (representedObject.domNode)
- return WebInspector.ContentView.createFromRepresentedObject(representedObject.domNode, extraArguments);
- }
-
- if (representedObject instanceof WebInspector.XHRBreakpoint)
- return WebInspector.ContentView.createFromRepresentedObject(WebInspector.frameResourceManager.mainFrame.domTree, extraArguments);
-
if (representedObject instanceof WebInspector.SourceCodeSearchMatchObject) {
var resultView;
if (representedObject.sourceCode instanceof WebInspector.Resource)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js (215112 => 215113)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2017-04-07 19:28:09 UTC (rev 215112)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2017-04-07 19:31:06 UTC (rev 215113)
@@ -643,6 +643,8 @@
|| treeElement instanceof WebInspector.ApplicationCacheManifestTreeElement
|| treeElement instanceof WebInspector.ThreadTreeElement
|| treeElement instanceof WebInspector.IdleTreeElement
+ || treeElement instanceof WebInspector.DOMBreakpointTreeElement
+ || treeElement instanceof WebInspector.XHRBreakpointTreeElement
|| typeof treeElement.representedObject === "string"
|| treeElement.representedObject instanceof String;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
