Title: [99430] trunk/Source/WebCore
- Revision
- 99430
- Author
- [email protected]
- Date
- 2011-11-07 09:15:36 -0800 (Mon, 07 Nov 2011)
Log Message
Web Inspector: TextPrompt+SuggestBox should autocomplete on "Right" keydown and with a single suggestion in place
https://bugs.webkit.org/show_bug.cgi?id=71676
Reviewed by Pavel Feldman.
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
* inspector/front-end/inspectorCommon.css:
(body): Revert inadvertent style change from a preceding commit.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (99429 => 99430)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 16:51:28 UTC (rev 99429)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 17:15:36 UTC (rev 99430)
@@ -1,3 +1,16 @@
+2011-11-07 Alexander Pavlov <[email protected]>
+
+ Web Inspector: TextPrompt+SuggestBox should autocomplete on "Right" keydown and with a single suggestion in place
+ https://bugs.webkit.org/show_bug.cgi?id=71676
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/TextPrompt.js:
+ (WebInspector.TextPrompt.prototype.onKeyDown):
+ (WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
+ * inspector/front-end/inspectorCommon.css:
+ (body): Revert inadvertent style change from a preceding commit.
+
2011-11-07 Tor Arne Vestbø <[email protected]>
Fix the Qt build on Mac OS X when using the QuickTime media backend
Modified: trunk/Source/WebCore/inspector/front-end/TextPrompt.js (99429 => 99430)
--- trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 16:51:28 UTC (rev 99429)
+++ trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 17:15:36 UTC (rev 99430)
@@ -228,8 +228,13 @@
break;
case "Right":
case "End":
- if (!this.acceptAutoComplete())
- this.autoCompleteSoon();
+ if (this.isSuggestBoxVisible())
+ handled = this._suggestBox.tabKeyPressed(event);
+ else {
+ handled = this.acceptAutoComplete();
+ if (!handled)
+ this.autoCompleteSoon();
+ }
break;
case "U+001B": // Esc
if (this.isSuggestBoxVisible()) {
@@ -1018,8 +1023,6 @@
var childText = child ? child.textContent : null;
this.contentElement.removeChildren();
- delete this._selectedElement;
-
var userEnteredText = this._textPrompt._userEnteredText;
for (var i = 0; i < items.length; ++i) {
var item = items[i];
@@ -1027,6 +1030,7 @@
this.contentElement.appendChild(currentItemElement);
}
+ this._selectedElement = this.contentElement.firstChild;
this._updateSelection();
},
Modified: trunk/Source/WebCore/inspector/front-end/inspectorCommon.css (99429 => 99430)
--- trunk/Source/WebCore/inspector/front-end/inspectorCommon.css 2011-11-07 16:51:28 UTC (rev 99429)
+++ trunk/Source/WebCore/inspector/front-end/inspectorCommon.css 2011-11-07 17:15:36 UTC (rev 99430)
@@ -13,6 +13,7 @@
font-family: Lucida Grande, sans-serif;
font-size: 10px;
margin: 0;
+ -webkit-text-size-adjust: none;
-webkit-user-select: none;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
