Diff
Modified: trunk/LayoutTests/ChangeLog (99434 => 99435)
--- trunk/LayoutTests/ChangeLog 2011-11-07 17:48:41 UTC (rev 99434)
+++ trunk/LayoutTests/ChangeLog 2011-11-07 17:51:09 UTC (rev 99435)
@@ -1,3 +1,16 @@
+2011-11-07 Dominic Cooney <[email protected]>
+
+ Remove initOverflowEvent from _javascript_ bindings
+ https://bugs.webkit.org/show_bug.cgi?id=71687
+
+ Reviewed by Ojan Vafai.
+
+ OverflowEvent initialization is tested in
+ fast/events/constructors/overflow-event-constructor.html
+
+ * fast/events/init-events-expected.txt:
+ * fast/events/script-tests/init-events.js:
+
2011-11-07 Philippe Normand <[email protected]>
[GTK] fast/frames/flattening/frameset-flattening-simple.html is flaky
Modified: trunk/LayoutTests/fast/events/init-events-expected.txt (99434 => 99435)
--- trunk/LayoutTests/fast/events/init-events-expected.txt 2011-11-07 17:48:41 UTC (rev 99434)
+++ trunk/LayoutTests/fast/events/init-events-expected.txt 2011-11-07 17:51:09 UTC (rev 99435)
@@ -116,15 +116,6 @@
PASS testInitEvent('Mutation', '"a", false, false, null, "b", "c", "d", 1001').attrName is 'd'
PASS testInitEvent('Mutation', '"a", false, false, null, "b", "c", null, 1001').attrName is 'null'
PASS testInitEvent('Mutation', '"a", false, false, null, "b", "c", "d", 1001').attrChange is 1001
-PASS testInitEvent('Overflow', '1001, false, false').type is 'overflowchanged'
-PASS testInitEvent('Overflow', '1001, false, false').bubbles is false
-PASS testInitEvent('Overflow', '1001, false, false').cancelable is false
-PASS testInitEvent('Overflow', '1001, false, false').orient is 1001
-PASS testInitEvent('Overflow', '1001, false, false').horizontalOverflow is false
-PASS testInitEvent('Overflow', '1001, true, false').horizontalOverflow is true
-PASS testInitEvent('Overflow', '1001, false, false').verticalOverflow is false
-PASS testInitEvent('Overflow', '1001, false, true').verticalOverflow is true
-PASS createEventHelper('Overflow').orient is OverflowEvent.VERTICAL
PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').type is 'a'
PASS testInitEvent('Progress', 'null, false, false, false, 1001, 1002').type is 'null'
PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').bubbles is false
Modified: trunk/LayoutTests/fast/events/script-tests/init-events.js (99434 => 99435)
--- trunk/LayoutTests/fast/events/script-tests/init-events.js 2011-11-07 17:48:41 UTC (rev 99434)
+++ trunk/LayoutTests/fast/events/script-tests/init-events.js 2011-11-07 17:51:09 UTC (rev 99435)
@@ -130,17 +130,6 @@
shouldBe("testInitEvent('Mutation', '\"a\", false, false, null, \"b\", \"c\", null, 1001').attrName", "'null'");
shouldBe("testInitEvent('Mutation', '\"a\", false, false, null, \"b\", \"c\", \"d\", 1001').attrChange", "1001");
-// initOverflowEvent has an interface that has an design that's inconsistent with the init functions from other events.
-shouldBe("testInitEvent('Overflow', '1001, false, false').type", "'overflowchanged'");
-shouldBe("testInitEvent('Overflow', '1001, false, false').bubbles", "false");
-shouldBe("testInitEvent('Overflow', '1001, false, false').cancelable", "false");
-shouldBe("testInitEvent('Overflow', '1001, false, false').orient", "1001");
-shouldBe("testInitEvent('Overflow', '1001, false, false').horizontalOverflow", "false");
-shouldBe("testInitEvent('Overflow', '1001, true, false').horizontalOverflow", "true");
-shouldBe("testInitEvent('Overflow', '1001, false, false').verticalOverflow", "false");
-shouldBe("testInitEvent('Overflow', '1001, false, true').verticalOverflow", "true");
-shouldBe("createEventHelper('Overflow').orient", "OverflowEvent.VERTICAL");
-
shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').type", "'a'");
shouldBe("testInitEvent('Progress', 'null, false, false, false, 1001, 1002').type", "'null'");
shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').bubbles", "false");
Modified: trunk/Source/WebCore/ChangeLog (99434 => 99435)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 17:48:41 UTC (rev 99434)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 17:51:09 UTC (rev 99435)
@@ -1,3 +1,16 @@
+2011-11-07 Dominic Cooney <[email protected]>
+
+ Remove initOverflowEvent from _javascript_ bindings
+ https://bugs.webkit.org/show_bug.cgi?id=71687
+
+ Reviewed by Ojan Vafai.
+
+ Now that OverflowEvent has a constructor, we don't need the
+ initOverflowEvent method. It has to remain in the Objective C
+ binding because it is part of the Objective C public API.
+
+ * dom/OverflowEvent.idl:
+
2011-11-07 Noel Gordon <[email protected]>
Refactor canvas encoding mimeType validation
Modified: trunk/Source/WebCore/dom/OverflowEvent.idl (99434 => 99435)
--- trunk/Source/WebCore/dom/OverflowEvent.idl 2011-11-07 17:48:41 UTC (rev 99434)
+++ trunk/Source/WebCore/dom/OverflowEvent.idl 2011-11-07 17:51:09 UTC (rev 99435)
@@ -37,9 +37,11 @@
readonly attribute boolean horizontalOverflow;
readonly attribute boolean verticalOverflow;
+#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
void initOverflowEvent(in [Optional=CallWithDefaultValue] unsigned short orient,
in [Optional=CallWithDefaultValue] boolean horizontalOverflow,
in [Optional=CallWithDefaultValue] boolean verticalOverflow);
+#endif
};
}
