Title: [99447] trunk/Source/WebCore
- Revision
- 99447
- Author
- [email protected]
- Date
- 2011-11-07 11:12:08 -0800 (Mon, 07 Nov 2011)
Log Message
Unreviewed, rolling out r99432.
http://trac.webkit.org/changeset/99432
https://bugs.webkit.org/show_bug.cgi?id=71709
It made layout tests extra slow on all bots (Requested by
Ossy_night on #webkit).
Patch by Sheriff Bot <[email protected]> on 2011-11-07
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (99446 => 99447)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 19:10:40 UTC (rev 99446)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 19:12:08 UTC (rev 99447)
@@ -1,3 +1,18 @@
+2011-11-07 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r99432.
+ http://trac.webkit.org/changeset/99432
+ https://bugs.webkit.org/show_bug.cgi?id=71709
+
+ It made layout tests extra slow on all bots (Requested by
+ Ossy_night on #webkit).
+
+ * inspector/front-end/ConsoleView.js:
+ (WebInspector.ConsoleView):
+ * inspector/front-end/TextPrompt.js:
+ (WebInspector.TextPrompt.prototype._attachInternal):
+ (WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):
+
2011-11-07 Andreas Kling <[email protected]>
REGRESSION(r99409): Broke transitions/clip-transition.html
Modified: trunk/Source/WebCore/inspector/front-end/ConsoleView.js (99446 => 99447)
--- trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-11-07 19:10:40 UTC (rev 99446)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-11-07 19:12:08 UTC (rev 99447)
@@ -61,6 +61,7 @@
this.promptElement.id = "console-prompt";
this.promptElement.className = "source-code";
this.promptElement.spellcheck = false;
+ this.promptElement.addEventListener("keydown", this._promptKeyDown.bind(this), true);
this.messagesElement.appendChild(this.promptElement);
this.messagesElement.appendChild(document.createElement("br"));
@@ -113,7 +114,6 @@
this.prompt = new WebInspector.TextPromptWithHistory(this.completions.bind(this), ExpressionStopCharacters + ".");
this.prompt.setSuggestBoxEnabled("generic-suggest");
this.prompt.attach(this.promptElement);
- this.prompt.proxyElement.addEventListener("keydown", this._promptKeyDown.bind(this), false);
this.prompt.setHistoryData(WebInspector.settings.consoleHistory.get());
}
Modified: trunk/Source/WebCore/inspector/front-end/TextPrompt.js (99446 => 99447)
--- trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 19:10:40 UTC (rev 99446)
+++ trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 19:12:08 UTC (rev 99447)
@@ -105,7 +105,7 @@
element.parentElement.insertBefore(this.proxyElement, element);
this.proxyElement.appendChild(element);
this._element.addStyleClass("text-prompt");
- this._element.addEventListener("keydown", this._boundOnKeyDown, false);
+ this._element.addEventListener("keydown", this._boundOnKeyDown, true);
this._element.addEventListener("selectstart", this._selectStart.bind(this), false);
if (typeof this._suggestBoxClassName === "string")
@@ -1078,8 +1078,7 @@
enterKeyPressed: function(event)
{
- this.acceptSuggestion();
- return true;
+ return this.acceptSuggestion();
},
tabKeyPressed: function(event)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
