Title: [215503] trunk/Websites/perf.webkit.org
- Revision
- 215503
- Author
- [email protected]
- Date
- 2017-04-18 22:58:44 -0700 (Tue, 18 Apr 2017)
Log Message
Build fix after r215061.
There was a mismatch between the format updateTriggerable and /api/update-triggerable were using.
Namely, each repository group was assumed to contain a name field in /api/update-triggerable
but updateTriggerable was not including that at all.
We didn't catch this because the test for updateTriggerable also used the wrong format :(
* server-tests/tools-buildbot-triggerable-tests.js:
* tools/js/buildbot-triggerable.js:
(BuildbotTriggerable.prototype.updateTriggerable):
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (215502 => 215503)
--- trunk/Websites/perf.webkit.org/ChangeLog 2017-04-19 04:22:19 UTC (rev 215502)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2017-04-19 05:58:44 UTC (rev 215503)
@@ -1,3 +1,17 @@
+2017-04-18 Ryosuke Niwa <[email protected]>
+
+ Build fix after r215061.
+
+ There was a mismatch between the format updateTriggerable and /api/update-triggerable were using.
+ Namely, each repository group was assumed to contain a name field in /api/update-triggerable
+ but updateTriggerable was not including that at all.
+
+ We didn't catch this because the test for updateTriggerable also used the wrong format :(
+
+ * server-tests/tools-buildbot-triggerable-tests.js:
+ * tools/js/buildbot-triggerable.js:
+ (BuildbotTriggerable.prototype.updateTriggerable):
+
2017-04-14 Dewei Zhu <[email protected]>
Add sub-commit UI in commit log viewer.
Modified: trunk/Websites/perf.webkit.org/server-tests/tools-buildbot-triggerable-tests.js (215502 => 215503)
--- trunk/Websites/perf.webkit.org/server-tests/tools-buildbot-triggerable-tests.js 2017-04-19 04:22:19 UTC (rev 215502)
+++ trunk/Websites/perf.webkit.org/server-tests/tools-buildbot-triggerable-tests.js 2017-04-19 05:58:44 UTC (rev 215503)
@@ -954,10 +954,10 @@
assert.deepEqual(groups[0].repositories(), [webkit, macos]);
const config = MockData.mockTestSyncConfigWithSingleBuilder();
- config.repositoryGroups = [
- {name: 'system-only', repositories: ['macOS'], properties: {'os': '<macOS>'}},
- {name: 'system-and-webkit', repositories: ['WebKit', 'macOS'], properties: {'os': '<macOS>', 'wk': '<WebKit>'}},
- ]
+ config.repositoryGroups = {
+ 'system-only': {repositories: ['macOS'], properties: {'os': '<macOS>'}},
+ 'system-and-webkit': {repositories: ['WebKit', 'macOS'], properties: {'os': '<macOS>', 'wk': '<WebKit>'}}
+ }
const logger = new MockLogger;
const slaveInfo = {name: 'sync-slave', password: 'password'};
Modified: trunk/Websites/perf.webkit.org/tools/js/buildbot-triggerable.js (215502 => 215503)
--- trunk/Websites/perf.webkit.org/tools/js/buildbot-triggerable.js 2017-04-19 04:22:19 UTC (rev 215502)
+++ trunk/Websites/perf.webkit.org/tools/js/buildbot-triggerable.js 2017-04-19 05:58:44 UTC (rev 215503)
@@ -44,7 +44,9 @@
'slavePassword': this._slaveInfo.password,
'triggerable': this._name,
'configurations': Array.from(map.values()),
- 'repositoryGroups': Object.keys(repositoryGroups).map((groupName) => repositoryGroups[groupName])});
+ 'repositoryGroups': Object.keys(repositoryGroups).map((groupName) => {
+ return {name: groupName, repositories: repositoryGroups[groupName].repositories};
+ })});
}
syncOnce()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
