Title: [215506] trunk/Source/WebCore
- Revision
- 215506
- Author
- [email protected]
- Date
- 2017-04-19 01:41:29 -0700 (Wed, 19 Apr 2017)
Log Message
Non-muxable GPUs shouldn't allow offline rendering
https://bugs.webkit.org/show_bug.cgi?id=170984
<rdar://problem/31614406>
Reviewed by Myles Maxfield.
Setting the kCGLPFAAllowOfflineRenderers flag doesn't do any
harm on devices that only have one GPU. It's also what we
want on devices that can mux between GPUs. However, we were
also setting it unconditionally on devices with multiple
GPUs that have issues muxing.
* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::setPixelFormat): Add a test for hasMuxableGPU.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (215505 => 215506)
--- trunk/Source/WebCore/ChangeLog 2017-04-19 07:42:12 UTC (rev 215505)
+++ trunk/Source/WebCore/ChangeLog 2017-04-19 08:41:29 UTC (rev 215506)
@@ -1,3 +1,20 @@
+2017-04-19 Dean Jackson <[email protected]>
+
+ Non-muxable GPUs shouldn't allow offline rendering
+ https://bugs.webkit.org/show_bug.cgi?id=170984
+ <rdar://problem/31614406>
+
+ Reviewed by Myles Maxfield.
+
+ Setting the kCGLPFAAllowOfflineRenderers flag doesn't do any
+ harm on devices that only have one GPU. It's also what we
+ want on devices that can mux between GPUs. However, we were
+ also setting it unconditionally on devices with multiple
+ GPUs that have issues muxing.
+
+ * platform/graphics/mac/GraphicsContext3DMac.mm:
+ (WebCore::setPixelFormat): Add a test for hasMuxableGPU.
+
2017-04-18 Youenn Fablet <[email protected]>
RTCOfferOptions iceRestart should be supported
Modified: trunk/Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm (215505 => 215506)
--- trunk/Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm 2017-04-19 07:42:12 UTC (rev 215505)
+++ trunk/Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm 2017-04-19 08:41:29 UTC (rev 215506)
@@ -331,7 +331,8 @@
// allowing us to request the integrated graphics on a dual GPU
// system, and not force the discrete GPU.
// See https://developer.apple.com/library/mac/technotes/tn2229/_index.html
- attribs.append(kCGLPFAAllowOfflineRenderers);
+ if (hasMuxableGPU())
+ attribs.append(kCGLPFAAllowOfflineRenderers);
if (accelerated)
attribs.append(kCGLPFAAccelerated);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
