Title: [215523] trunk/Tools
- Revision
- 215523
- Author
- [email protected]
- Date
- 2017-04-19 11:57:49 -0700 (Wed, 19 Apr 2017)
Log Message
close_fds should be set to False on Windows.
https://bugs.webkit.org/show_bug.cgi?id=170838
Patch by Bill Ming <[email protected]> on 2017-04-19
Reviewed by Brent Fulgham.
* Scripts/webkitpy/common/system/executive.py:
(Executive._should_close_fds):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (215522 => 215523)
--- trunk/Tools/ChangeLog 2017-04-19 18:25:43 UTC (rev 215522)
+++ trunk/Tools/ChangeLog 2017-04-19 18:57:49 UTC (rev 215523)
@@ -1,3 +1,13 @@
+2017-04-19 Bill Ming <[email protected]>
+
+ close_fds should be set to False on Windows.
+ https://bugs.webkit.org/show_bug.cgi?id=170838
+
+ Reviewed by Brent Fulgham.
+
+ * Scripts/webkitpy/common/system/executive.py:
+ (Executive._should_close_fds):
+
2017-04-19 David Kilzer <[email protected]>
Stop using strcpy() in WebKit::EnvironmentUtilities::stripValuesEndingWithString()
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive.py (215522 => 215523)
--- trunk/Tools/Scripts/webkitpy/common/system/executive.py 2017-04-19 18:25:43 UTC (rev 215522)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive.py 2017-04-19 18:57:49 UTC (rev 215523)
@@ -92,7 +92,12 @@
# (otherwise we can hang when we kill DumpRenderTree when we are running
# multiple threads). See http://bugs.python.org/issue2320 .
# In Python 2.7.10, close_fds is also supported on Windows.
- return True
+ # However, "you cannot set close_fds to true and also redirect the standard
+ # handles by setting stdin, stdout or stderr.".
+ if sys.platform.startswith('win'):
+ return False
+ else:
+ return True
def _run_command_with_teed_output(self, args, teed_output, **kwargs):
child_process = self.popen(args,
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
