Title: [215532] trunk
- Revision
- 215532
- Author
- [email protected]
- Date
- 2017-04-19 14:58:05 -0700 (Wed, 19 Apr 2017)
Log Message
AX: <hr> should use a different role description than interactive separators
https://bugs.webkit.org/show_bug.cgi?id=170317
<rdar://problem/31363024>
Reviewed by Joanmarie Diggs.
Source/WebCore:
Users are confused with WebKit's accessibility description of separators.
We should call these what they are, horizontal rules.
Updated test: accessibility/mac/hr-element-expected.txt
* English.lproj/Localizable.strings:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::orientation):
* platform/cocoa/LocalizedStringsCocoa.mm:
(WebCore::AXHorizontalRuleDescriptionText):
LayoutTests:
* accessibility/mac/hr-element-expected.txt:
* accessibility/mac/hr-element.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (215531 => 215532)
--- trunk/LayoutTests/ChangeLog 2017-04-19 21:51:52 UTC (rev 215531)
+++ trunk/LayoutTests/ChangeLog 2017-04-19 21:58:05 UTC (rev 215532)
@@ -1,3 +1,14 @@
+2017-04-19 Chris Fleizach <[email protected]>
+
+ AX: <hr> should use a different role description than interactive separators
+ https://bugs.webkit.org/show_bug.cgi?id=170317
+ <rdar://problem/31363024>
+
+ Reviewed by Joanmarie Diggs.
+
+ * accessibility/mac/hr-element-expected.txt:
+ * accessibility/mac/hr-element.html:
+
2017-04-19 JF Bastien <[email protected]>
Unreviewed, rolling out r215520.
Modified: trunk/LayoutTests/accessibility/mac/hr-element-expected.txt (215531 => 215532)
--- trunk/LayoutTests/accessibility/mac/hr-element-expected.txt 2017-04-19 21:51:52 UTC (rev 215531)
+++ trunk/LayoutTests/accessibility/mac/hr-element-expected.txt 2017-04-19 21:58:05 UTC (rev 215532)
@@ -5,25 +5,36 @@
hr1 role: AXRole: AXSplitter
hr1 subrole: AXSubrole: AXContentSeparator
-hr1 roleDescription: AXRoleDescription: separator
+hr1 roleDescription: AXRoleDescription: rule
hr1 description: AXDescription:
hr1 is value settable: false
+hr1 orientation: AXOrientation: AXHorizontalOrientation
hr1 is enabled: false
hr2 role: AXRole: AXSplitter
hr2 subrole: AXSubrole: AXContentSeparator
-hr2 roleDescription: AXRoleDescription: separator
+hr2 roleDescription: AXRoleDescription: rule
hr2 description: AXDescription:
hr2 is value settable: false
+hr2 orientation: AXOrientation: AXHorizontalOrientation
hr2 is enabled: false
hr3 role: AXRole: AXSplitter
hr3 subrole: AXSubrole: AXContentSeparator
-hr3 roleDescription: AXRoleDescription: separator
+hr3 roleDescription: AXRoleDescription: rule
hr3 description: AXDescription: RULER
hr3 is value settable: false
+hr3 orientation: AXOrientation: AXHorizontalOrientation
hr3 is enabled: false
+hr4 role: AXRole: AXSplitter
+hr4 subrole: AXSubrole: AXContentSeparator
+hr4 roleDescription: AXRoleDescription: rule
+hr4 description: AXDescription:
+hr4 is value settable: false
+hr4 orientation: AXOrientation: AXVerticalOrientation
+hr4 is enabled: false
+
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/accessibility/mac/hr-element.html (215531 => 215532)
--- trunk/LayoutTests/accessibility/mac/hr-element.html 2017-04-19 21:51:52 UTC (rev 215531)
+++ trunk/LayoutTests/accessibility/mac/hr-element.html 2017-04-19 21:58:05 UTC (rev 215532)
@@ -11,6 +11,8 @@
<hr id="hr2">
<hr id="hr3" aria-label="RULER" tabindex="0">
+
+<hr id="hr4" aria-orientation="vertical">
</div>
<p id="description"></p>
@@ -22,7 +24,7 @@
if (window.accessibilityController) {
- for (var k = 1; k <= 3; k++) {
+ for (var k = 1; k <= 4; k++) {
var hr = accessibilityController.accessibleElementById("hr" + k);
debug("hr" + k + " role: " + hr.role);
debug("hr" + k + " subrole: " + hr.subrole);
@@ -29,6 +31,7 @@
debug("hr" + k + " roleDescription: " + hr.roleDescription);
debug("hr" + k + " description: " + hr.description);
debug("hr" + k + " is value settable: " + hr.isAttributeSettable('AXValue'));
+ debug("hr" + k + " orientation: " + hr.orientation);
debug("hr" + k + " is enabled: " + hr.isEnabled + "\n");
}
document.getElementById("content").style.visibility = "none";
Modified: trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt (215531 => 215532)
--- trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt 2017-04-19 21:51:52 UTC (rev 215531)
+++ trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt 2017-04-19 21:58:05 UTC (rev 215532)
@@ -182,7 +182,7 @@
hr
AXRole: AXSplitter
AXSubrole: AXContentSeparator
- AXRoleDescription: separator
+ AXRoleDescription: rule
i
AXRole:
Modified: trunk/Source/WebCore/ChangeLog (215531 => 215532)
--- trunk/Source/WebCore/ChangeLog 2017-04-19 21:51:52 UTC (rev 215531)
+++ trunk/Source/WebCore/ChangeLog 2017-04-19 21:58:05 UTC (rev 215532)
@@ -1,3 +1,22 @@
+2017-04-19 Chris Fleizach <[email protected]>
+
+ AX: <hr> should use a different role description than interactive separators
+ https://bugs.webkit.org/show_bug.cgi?id=170317
+ <rdar://problem/31363024>
+
+ Reviewed by Joanmarie Diggs.
+
+ Users are confused with WebKit's accessibility description of separators.
+ We should call these what they are, horizontal rules.
+
+ Updated test: accessibility/mac/hr-element-expected.txt
+
+ * English.lproj/Localizable.strings:
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::orientation):
+ * platform/cocoa/LocalizedStringsCocoa.mm:
+ (WebCore::AXHorizontalRuleDescriptionText):
+
2017-04-19 Anders Carlsson <[email protected]>
Rename cancelPayment to cancelPaymentSession
Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (215531 => 215532)
--- trunk/Source/WebCore/English.lproj/Localizable.strings 2017-04-19 21:51:52 UTC (rev 215531)
+++ trunk/Source/WebCore/English.lproj/Localizable.strings 2017-04-19 21:58:05 UTC (rev 215532)
@@ -1115,7 +1115,7 @@
"select" = "select";
/* accessibility role description for a horizontal rule [<hr>] */
-"separator" = "separator";
+"rule" = "rule";
/* HTTP result code string */
"server error" = "server error";
Modified: trunk/Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm (215531 => 215532)
--- trunk/Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm 2017-04-19 21:51:52 UTC (rev 215531)
+++ trunk/Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm 2017-04-19 21:58:05 UTC (rev 215532)
@@ -230,7 +230,7 @@
String AXHorizontalRuleDescriptionText()
{
- return WEB_UI_STRING("separator", "accessibility role description for a horizontal rule [<hr>]");
+ return WEB_UI_STRING("rule", "accessibility role description for a horizontal rule [<hr>]");
}
String AXMarkText()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
