Diff
Modified: trunk/LayoutTests/ChangeLog (99470 => 99471)
--- trunk/LayoutTests/ChangeLog 2011-11-07 21:30:41 UTC (rev 99470)
+++ trunk/LayoutTests/ChangeLog 2011-11-07 21:59:19 UTC (rev 99471)
@@ -1,3 +1,12 @@
+2011-11-07 Dominic Cooney <[email protected]>
+
+ Remove initPopStateEvent method
+ https://bugs.webkit.org/show_bug.cgi?id=71691
+
+ Reviewed by Ojan Vafai.
+
+ * fast/events/fire-popstate-event.html: use 'new PopStateEvent' now
+
2011-11-07 Adam Barth <[email protected]>
iframe sandbox treats vertical tab as a valid delimiter
Modified: trunk/LayoutTests/fast/events/fire-popstate-event.html (99470 => 99471)
--- trunk/LayoutTests/fast/events/fire-popstate-event.html 2011-11-07 21:30:41 UTC (rev 99470)
+++ trunk/LayoutTests/fast/events/fire-popstate-event.html 2011-11-07 21:59:19 UTC (rev 99471)
@@ -15,8 +15,11 @@
_onload_ = function()
{
- var evt = document.createEvent("PopStateEvent");
- evt.initPopStateEvent("popstate", false, false, { testValue: "Success"} );
+ var evt = new PopStateEvent('popstate', {
+ bubbles: false,
+ cancelable: false,
+ state: { testValue: 'Success' }
+ });
window.dispatchEvent(evt);
}
Modified: trunk/Source/WebCore/ChangeLog (99470 => 99471)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 21:30:41 UTC (rev 99470)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 21:59:19 UTC (rev 99471)
@@ -1,3 +1,14 @@
+2011-11-07 Dominic Cooney <[email protected]>
+
+ Remove initPopStateEvent method
+ https://bugs.webkit.org/show_bug.cgi?id=71691
+
+ Reviewed by Ojan Vafai.
+
+ * dom/PopStateEvent.cpp:
+ * dom/PopStateEvent.h:
+ * dom/PopStateEvent.idl:
+
2011-11-07 Andreas Kling <[email protected]>
CSSValue: Devirtualize isFooType().
Modified: trunk/Source/WebCore/dom/PopStateEvent.cpp (99470 => 99471)
--- trunk/Source/WebCore/dom/PopStateEvent.cpp 2011-11-07 21:30:41 UTC (rev 99470)
+++ trunk/Source/WebCore/dom/PopStateEvent.cpp 2011-11-07 21:59:19 UTC (rev 99471)
@@ -85,16 +85,6 @@
return adoptRef(new PopStateEvent(type, initializer));
}
-void PopStateEvent::initPopStateEvent(const AtomicString& type, bool canBubble, bool cancelable, const ScriptValue& state)
-{
- if (dispatched())
- return;
-
- initEvent(type, canBubble, cancelable);
-
- m_state = state;
-}
-
const AtomicString& PopStateEvent::interfaceName() const
{
return eventNames().interfaceForPopStateEvent;
Modified: trunk/Source/WebCore/dom/PopStateEvent.h (99470 => 99471)
--- trunk/Source/WebCore/dom/PopStateEvent.h 2011-11-07 21:30:41 UTC (rev 99470)
+++ trunk/Source/WebCore/dom/PopStateEvent.h 2011-11-07 21:59:19 UTC (rev 99471)
@@ -46,7 +46,6 @@
static PassRefPtr<PopStateEvent> create(const ScriptValue&);
static PassRefPtr<PopStateEvent> create(PassRefPtr<SerializedScriptValue>);
static PassRefPtr<PopStateEvent> create(const AtomicString&, const PopStateEventInit&);
- void initPopStateEvent(const AtomicString& type, bool canBubble, bool cancelable, const ScriptValue&);
SerializedScriptValue* serializedState() const { return m_serializedState.get(); }
ScriptValue state() const { return m_state; }
Modified: trunk/Source/WebCore/dom/PopStateEvent.idl (99470 => 99471)
--- trunk/Source/WebCore/dom/PopStateEvent.idl 2011-11-07 21:30:41 UTC (rev 99470)
+++ trunk/Source/WebCore/dom/PopStateEvent.idl 2011-11-07 21:59:19 UTC (rev 99471)
@@ -31,11 +31,6 @@
CanBeConstructed,
CustomConstructor,
] PopStateEvent : Event {
- void initPopStateEvent(in [Optional=CallWithDefaultValue] DOMString typeArg,
- in [Optional=CallWithDefaultValue] boolean canBubbleArg,
- in [Optional=CallWithDefaultValue] boolean cancelableArg,
- in [Optional=CallWithDefaultValue] DOMObject stateArg);
-
readonly attribute [CustomGetter] DOMObject state;
};
#endif
