Diff
Modified: trunk/LayoutTests/ChangeLog (215563 => 215564)
--- trunk/LayoutTests/ChangeLog 2017-04-20 17:49:37 UTC (rev 215563)
+++ trunk/LayoutTests/ChangeLog 2017-04-20 17:53:11 UTC (rev 215564)
@@ -1,3 +1,14 @@
+2017-04-20 Jon Lee <[email protected]>
+
+ Update pip placard to "picture in picture"
+ https://bugs.webkit.org/show_bug.cgi?id=171036
+ rdar://problem/30201536
+
+ Reviewed by Antoine Quint.
+
+ * media/modern-media-controls/pip-placard/pip-placard-expected.txt: Updated expected results.
+ * media/modern-media-controls/pip-placard/pip-placard.html:
+
2017-04-20 Ryan Haddad <[email protected]>
Mark two crypto/subtle/ecdsa LayoutTests as flaky.
Modified: trunk/LayoutTests/media/modern-media-controls/pip-placard/pip-placard-expected.txt (215563 => 215564)
--- trunk/LayoutTests/media/modern-media-controls/pip-placard/pip-placard-expected.txt 2017-04-20 17:49:37 UTC (rev 215563)
+++ trunk/LayoutTests/media/modern-media-controls/pip-placard/pip-placard-expected.txt 2017-04-20 17:53:11 UTC (rev 215564)
@@ -5,7 +5,7 @@
Placard with all parameters
PASS placard.children[0].children[0].iconName is Icons.PiPPlacard
-PASS placard.children[0].children[1].element.innerText is "This video is playing in Picture in Picture"
+PASS placard.children[0].children[1].element.innerText is "This video is playing in picture in picture."
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/media/modern-media-controls/pip-placard/pip-placard.html (215563 => 215564)
--- trunk/LayoutTests/media/modern-media-controls/pip-placard/pip-placard.html 2017-04-20 17:49:37 UTC (rev 215563)
+++ trunk/LayoutTests/media/modern-media-controls/pip-placard/pip-placard.html 2017-04-20 17:53:11 UTC (rev 215564)
@@ -9,7 +9,7 @@
const placard = new PiPPlacard({ layoutTraits: LayoutTraits.macOS });
shouldBe("placard.children[0].children[0].iconName", "Icons.PiPPlacard");
-shouldBeEqualToString("placard.children[0].children[1].element.innerText", "This video is playing in Picture in Picture");
+shouldBeEqualToString("placard.children[0].children[1].element.innerText", "This video is playing in picture in picture.");
</script>
<script src=""
Modified: trunk/Source/WebCore/ChangeLog (215563 => 215564)
--- trunk/Source/WebCore/ChangeLog 2017-04-20 17:49:37 UTC (rev 215563)
+++ trunk/Source/WebCore/ChangeLog 2017-04-20 17:53:11 UTC (rev 215564)
@@ -1,3 +1,22 @@
+2017-04-20 Jon Lee <[email protected]>
+
+ Update pip placard to "picture in picture"
+ https://bugs.webkit.org/show_bug.cgi?id=171036
+ rdar://problem/30201536
+
+ Reviewed by Antoine Quint.
+
+ Updated media/modern-media-controls/pip-placard/pip-placard.html
+
+ Update the text shown with the picture in picture placard.
+
+ * English.lproj/mediaControlsLocalizedStrings.js:
+ * English.lproj/modern-media-controls-localized-strings.js:
+ * Modules/mediacontrols/mediaControlsApple.js:
+ (Controller.prototype.updatePictureInPicturePlaceholder):
+ * Modules/modern-media-controls/controls/pip-placard.js:
+ (PiPPlacard):
+
2017-04-20 Youenn Fablet <[email protected]>
RTCPeerConnection is stopping its backend twice sometimes
Modified: trunk/Source/WebCore/English.lproj/mediaControlsLocalizedStrings.js (215563 => 215564)
--- trunk/Source/WebCore/English.lproj/mediaControlsLocalizedStrings.js 2017-04-20 17:49:37 UTC (rev 215563)
+++ trunk/Source/WebCore/English.lproj/mediaControlsLocalizedStrings.js 2017-04-20 17:53:11 UTC (rev 215564)
@@ -38,7 +38,7 @@
'Start Playback': 'Start Playback',
'Subtitles': 'Subtitles',
'Suspended': 'Suspended',
- 'This video is playing in Picture in Picture': 'This video is playing in Picture in Picture',
+ 'This video is playing in picture in picture.': 'This video is playing in picture in picture.',
'Unmute': 'Unmute',
'Video Playback': 'Video Playback',
'Video Playback Placeholder': 'Video Playback Placeholder',
Modified: trunk/Source/WebCore/English.lproj/modern-media-controls-localized-strings.js (215563 => 215564)
--- trunk/Source/WebCore/English.lproj/modern-media-controls-localized-strings.js 2017-04-20 17:49:37 UTC (rev 215563)
+++ trunk/Source/WebCore/English.lproj/modern-media-controls-localized-strings.js 2017-04-20 17:53:11 UTC (rev 215564)
@@ -20,7 +20,7 @@
"Scale to Fit": "Scale to Fit",
"Subtitles": "Subtitles",
"Start": "Start",
- "This video is playing in Picture in Picture": "This video is playing in Picture in Picture",
+ "This video is playing in picture in picture.": "This video is playing in picture in picture.",
"This video is playing on your Apple TV": "This video is playing on your Apple TV",
"Unmute": "Unmute",
"Volume": "Volume",
Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (215563 => 215564)
--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2017-04-20 17:49:37 UTC (rev 215563)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2017-04-20 17:53:11 UTC (rev 215564)
@@ -936,7 +936,7 @@
this.controls.inlinePlaybackPlaceholder.classList.add(this.ClassNames.pictureInPicture);
this.showInlinePlaybackPlaceholderWhenSafe();
- this.controls.inlinePlaybackPlaceholderTextTop.innerText = this.UIString('This video is playing in Picture in Picture');
+ this.controls.inlinePlaybackPlaceholderTextTop.innerText = this.UIString('This video is playing in picture in picture.');
this.controls.inlinePlaybackPlaceholderTextTop.classList.add(this.ClassNames.pictureInPicture);
this.controls.inlinePlaybackPlaceholderTextBottom.innerText = "";
this.controls.inlinePlaybackPlaceholderTextBottom.classList.add(this.ClassNames.pictureInPicture);
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/pip-placard.js (215563 => 215564)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/pip-placard.js 2017-04-20 17:49:37 UTC (rev 215563)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/pip-placard.js 2017-04-20 17:53:11 UTC (rev 215564)
@@ -30,7 +30,7 @@
{
super({
iconName: Icons.PiPPlacard,
- description: UIString("This video is playing in Picture in Picture"),
+ description: UIString("This video is playing in picture in picture."),
layoutDelegate
});
}
