> On 20 Apr 2017, at 21.47, Geoffrey Garen <[email protected]> wrote: > > Maybe we should use a % of system RAM so we don’t have to keep updating this > number.
Might be a good idea. I think ideally we wouldn’t need this number at all and would just rely on purgeable memory. antti > Geoff > >> On Apr 20, 2017, at 5:57 AM, [email protected] <mailto:[email protected]> wrote: >> >> Revision >> 215557 <http://trac.webkit.org/projects/webkit/changeset/215557>Author >> [email protected] <mailto:[email protected]>Date >> 2017-04-20 05:57:40 -0700 (Thu, 20 Apr 2017) >> Log Message >> >> Increase large animation cutoff >> https://bugs.webkit.org/show_bug.cgi?id=171051 >> <https://bugs.webkit.org/show_bug.cgi?id=171051> >> <rdar://problem/31731532 <rdar://problem/31731532>> >> >> Reviewed by Andreas Kling. >> >> We currently switch to per-frame decoding if the animation is larger than >> 5MB. This is very >> power-inefficient and such animations are now common. The cutoff originates >> from 2007 (r20069 <http://trac.webkit.org/projects/webkit/changeset/20069>), >> it is time update it. >> >> Note that the normal low memory handling will still kill animation frames as >> needed. >> >> * platform/graphics/BitmapImage.h: >> >> Increase cutoff to 30MB. This is enough (with some room to spare) for >> animations on current >> tumblr.com/search/aww <http://tumblr.com/search/aww>. >> >> Also remove the separate cutoff value for iOS. >> Modified Paths >> >> trunk/Source/WebCore/ChangeLog <x-msg://42/#trunkSourceWebCoreChangeLog> >> trunk/Source/WebCore/platform/graphics/BitmapImage.h >> <x-msg://42/#trunkSourceWebCoreplatformgraphicsBitmapImageh> >> Diff >> >> <>Modified: trunk/Source/WebCore/ChangeLog (215556 => 215557) >> >> --- trunk/Source/WebCore/ChangeLog 2017-04-20 10:24:37 UTC (rev 215556) >> +++ trunk/Source/WebCore/ChangeLog 2017-04-20 12:57:40 UTC (rev 215557) >> @@ -1,3 +1,24 @@ >> +2017-04-20 Antti Koivisto <[email protected] <mailto:[email protected]>> >> + >> + Increase large animation cutoff >> + https://bugs.webkit.org/show_bug.cgi?id=171051 >> <https://bugs.webkit.org/show_bug.cgi?id=171051> >> + <rdar://problem/31731532 <rdar://problem/31731532>> >> + >> + Reviewed by Andreas Kling. >> + >> + We currently switch to per-frame decoding if the animation is >> larger than 5MB. This is very >> + power-inefficient and such animations are now common. The cutoff >> originates from 2007 (r20069), >> + it is time update it. >> + >> + Note that the normal low memory handling will still kill animation >> frames as needed. >> + >> + * platform/graphics/BitmapImage.h: >> + >> + Increase cutoff to 30MB. This is enough (with some room to >> spare) for animations on current >> + tumblr.com/search/aww <http://tumblr.com/search/aww>. >> + >> + Also remove the separate cutoff value for iOS. >> + >> 2017-04-20 Zan Dobersek <[email protected] >> <mailto:[email protected]>> >> >> Register missing AES_CTR, ECDSA and HKDF algorithms in >> <>Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.h (215556 => >> 215557) >> >> --- trunk/Source/WebCore/platform/graphics/BitmapImage.h 2017-04-20 >> 10:24:37 UTC (rev 215556) >> +++ trunk/Source/WebCore/platform/graphics/BitmapImage.h 2017-04-20 >> 12:57:40 UTC (rev 215557) >> @@ -195,11 +195,7 @@ >> void dump(TextStream&) const override; >> >> // Animated images over a certain size are considered large enough that >> we'll only hang on to one frame at a time. >> -#if !PLATFORM(IOS) >> - static const unsigned LargeAnimationCutoff = 5242880; >> -#else >> - static const unsigned LargeAnimationCutoff = 2097152; >> -#endif >> + static const unsigned LargeAnimationCutoff = 30 * 1014 * 1024; >> >> mutable ImageSource m_source; >> >> _______________________________________________ >> webkit-changes mailing list >> [email protected] <mailto:[email protected]> >> https://lists.webkit.org/mailman/listinfo/webkit-changes >> <https://lists.webkit.org/mailman/listinfo/webkit-changes>
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
