Diff
Modified: trunk/Source/WebCore/ChangeLog (215684 => 215685)
--- trunk/Source/WebCore/ChangeLog 2017-04-24 17:21:00 UTC (rev 215684)
+++ trunk/Source/WebCore/ChangeLog 2017-04-24 17:26:23 UTC (rev 215685)
@@ -1,3 +1,17 @@
+2017-04-24 Dan Bernstein <m...@apple.com>
+
+ [Cocoa] Some ivars are needlessly @protected
+ https://bugs.webkit.org/show_bug.cgi?id=171208
+
+ Reviewed by Anders Carlsson.
+
+ Made ivars @private where possible.
+
+ * platform/mac/WebCoreFullScreenPlaceholderView.h:
+ * platform/mac/WebCoreFullScreenWarningView.h:
+ * platform/mac/WebPlaybackControlsManager.h:
+ * platform/network/cocoa/WebCoreNSURLSession.h:
+
2017-04-24 Carlos Garcia Campos <cgar...@igalia.com>
[GTK] Switch to use ENABLE_REMOTE_INSPECTOR instead of ENABLE_INSPECTOR_SERVER for the remote inspector
Modified: trunk/Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.h (215684 => 215685)
--- trunk/Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.h 2017-04-24 17:21:00 UTC (rev 215684)
+++ trunk/Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.h 2017-04-24 17:26:23 UTC (rev 215685)
@@ -31,6 +31,7 @@
#import <wtf/RetainPtr.h>
WEBCORE_EXPORT @interface WebCoreFullScreenPlaceholderView : NSView {
+@private
RetainPtr<NSVisualEffectView> _effectView;
RetainPtr<NSTextField> _exitWarning;
NSObject* _target;
Modified: trunk/Source/WebCore/platform/mac/WebCoreFullScreenWarningView.h (215684 => 215685)
--- trunk/Source/WebCore/platform/mac/WebCoreFullScreenWarningView.h 2017-04-24 17:21:00 UTC (rev 215684)
+++ trunk/Source/WebCore/platform/mac/WebCoreFullScreenWarningView.h 2017-04-24 17:26:23 UTC (rev 215685)
@@ -33,6 +33,7 @@
#include <wtf/RetainPtr.h>
WEBCORE_EXPORT @interface WebCoreFullScreenWarningView : NSBox {
+@private
RetainPtr<NSTextField> _textField;
}
- (id)initWithTitle:(NSString*)title;
Modified: trunk/Source/WebCore/platform/mac/WebPlaybackControlsManager.h (215684 => 215685)
--- trunk/Source/WebCore/platform/mac/WebPlaybackControlsManager.h 2017-04-24 17:21:00 UTC (rev 215684)
+++ trunk/Source/WebCore/platform/mac/WebPlaybackControlsManager.h 2017-04-24 17:26:23 UTC (rev 215685)
@@ -38,6 +38,7 @@
WEBCORE_EXPORT
@interface WebPlaybackControlsManager : NSObject <AVTouchBarPlaybackControlsControlling> {
+@private
NSTimeInterval _contentDuration;
RetainPtr<AVValueTiming> _timing;
NSTimeInterval _seekToTime;
@@ -51,7 +52,6 @@
float _rate;
BOOL _canTogglePlayback;
-@private
RefPtr<WebCore::WebPlaybackSessionInterfaceMac> _webPlaybackSessionInterfaceMac;
}
Modified: trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h (215684 => 215685)
--- trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h 2017-04-24 17:21:00 UTC (rev 215684)
+++ trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h 2017-04-24 17:26:23 UTC (rev 215685)
@@ -58,6 +58,7 @@
NS_ASSUME_NONNULL_BEGIN
WEBCORE_EXPORT @interface WebCoreNSURLSession : NSObject {
+@private
RefPtr<WebCore::PlatformMediaResourceLoader> _loader;
RetainPtr<id<NSURLSessionDelegate>> _delegate;
RetainPtr<NSOperationQueue> _queue;
Modified: trunk/Source/WebKit/mac/ChangeLog (215684 => 215685)
--- trunk/Source/WebKit/mac/ChangeLog 2017-04-24 17:21:00 UTC (rev 215684)
+++ trunk/Source/WebKit/mac/ChangeLog 2017-04-24 17:26:23 UTC (rev 215685)
@@ -1,3 +1,23 @@
+2017-04-24 Dan Bernstein <m...@apple.com>
+
+ [Cocoa] Some ivars are needlessly @protected
+ https://bugs.webkit.org/show_bug.cgi?id=171208
+
+ Reviewed by Anders Carlsson
+
+ Made ivars @private where possible.
+
+ * Misc/WebUserContentURLPattern.h:
+ * Plugins/WebPluginDatabase.h:
+ * Storage/WebDatabaseQuotaManager.h:
+ * WebCoreSupport/WebSecurityOriginPrivate.h:
+ * WebInspector/WebInspector.h:
+ * WebView/WebDeviceOrientation.h:
+ * WebView/WebDeviceOrientationProviderMock.h:
+ * WebView/WebGeolocationPosition.h:
+ * WebView/WebHTMLRepresentation.h:
+ * WebView/WebNotification.h:
+
2017-04-21 Wenson Hsieh <wenson_hs...@apple.com>
Support writing link titles to the pasteboard when beginning data interaction on a link
Modified: trunk/Source/WebKit/mac/Misc/WebUserContentURLPattern.h (215684 => 215685)
--- trunk/Source/WebKit/mac/Misc/WebUserContentURLPattern.h 2017-04-24 17:21:00 UTC (rev 215684)
+++ trunk/Source/WebKit/mac/Misc/WebUserContentURLPattern.h 2017-04-24 17:26:23 UTC (rev 215685)
@@ -25,6 +25,7 @@
@class WebUserContentURLPatternPrivate;
@interface WebUserContentURLPattern : NSObject {
+@private
WebUserContentURLPatternPrivate *_private;
}
Modified: trunk/Source/WebKit/mac/Plugins/WebPluginDatabase.h (215684 => 215685)
--- trunk/Source/WebKit/mac/Plugins/WebPluginDatabase.h 2017-04-24 17:21:00 UTC (rev 215684)
+++ trunk/Source/WebKit/mac/Plugins/WebPluginDatabase.h 2017-04-24 17:26:23 UTC (rev 215685)
@@ -37,6 +37,7 @@
@interface WebPluginDatabase : NSObject
{
+@private
NSMutableDictionary *plugins;
NSMutableSet *registeredMIMETypes;
NSArray *plugInPaths;
Modified: trunk/Source/WebKit/mac/Storage/WebDatabaseQuotaManager.h (215684 => 215685)
--- trunk/Source/WebKit/mac/Storage/WebDatabaseQuotaManager.h 2017-04-24 17:21:00 UTC (rev 215684)
+++ trunk/Source/WebKit/mac/Storage/WebDatabaseQuotaManager.h 2017-04-24 17:26:23 UTC (rev 215685)
@@ -26,6 +26,7 @@
#import "WebQuotaManager.h"
@interface WebDatabaseQuotaManager : NSObject <WebQuotaManager> {
+@private
WebSecurityOrigin *_origin;
}
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebSecurityOriginPrivate.h (215684 => 215685)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebSecurityOriginPrivate.h 2017-04-24 17:21:00 UTC (rev 215684)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebSecurityOriginPrivate.h 2017-04-24 17:26:23 UTC (rev 215685)
@@ -30,6 +30,7 @@
@protocol WebQuotaManager;
@interface WebSecurityOrigin : NSObject {
+@private
WebSecurityOriginPrivate *_private;
id<WebQuotaManager> _applicationCacheQuotaManager;
id<WebQuotaManager> _databaseQuotaManager;
Modified: trunk/Source/WebKit/mac/WebInspector/WebInspector.h (215684 => 215685)
--- trunk/Source/WebKit/mac/WebInspector/WebInspector.h 2017-04-24 17:21:00 UTC (rev 215684)
+++ trunk/Source/WebKit/mac/WebInspector/WebInspector.h 2017-04-24 17:26:23 UTC (rev 215685)
@@ -36,6 +36,7 @@
@interface WebInspector : NSObject
{
+@private
WebView *_inspectedWebView;
WebInspectorFrontend *_frontend;
}
Modified: trunk/Source/WebKit/mac/WebView/WebDeviceOrientation.h (215684 => 215685)
--- trunk/Source/WebKit/mac/WebView/WebDeviceOrientation.h 2017-04-24 17:21:00 UTC (rev 215684)
+++ trunk/Source/WebKit/mac/WebView/WebDeviceOrientation.h 2017-04-24 17:26:23 UTC (rev 215685)
@@ -27,6 +27,7 @@
@class WebDeviceOrientationInternal;
@interface WebDeviceOrientation : NSObject {
+@private
WebDeviceOrientationInternal* m_internal;
}
Modified: trunk/Source/WebKit/mac/WebView/WebDeviceOrientationProviderMock.h (215684 => 215685)
--- trunk/Source/WebKit/mac/WebView/WebDeviceOrientationProviderMock.h 2017-04-24 17:21:00 UTC (rev 215684)
+++ trunk/Source/WebKit/mac/WebView/WebDeviceOrientationProviderMock.h 2017-04-24 17:26:23 UTC (rev 215685)
@@ -29,6 +29,7 @@
@class WebDeviceOrientation;
@interface WebDeviceOrientationProviderMock : NSObject<WebDeviceOrientationProvider> {
+@private
WebDeviceOrientationProviderMockInternal* m_internal;
}
Modified: trunk/Source/WebKit/mac/WebView/WebGeolocationPosition.h (215684 => 215685)
--- trunk/Source/WebKit/mac/WebView/WebGeolocationPosition.h 2017-04-24 17:21:00 UTC (rev 215684)
+++ trunk/Source/WebKit/mac/WebView/WebGeolocationPosition.h 2017-04-24 17:26:23 UTC (rev 215685)
@@ -27,6 +27,7 @@
@interface WebGeolocationPosition : NSObject
{
+@private
WebGeolocationPositionInternal *_internal;
}
Modified: trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.h (215684 => 215685)
--- trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.h 2017-04-24 17:21:00 UTC (rev 215684)
+++ trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.h 2017-04-24 17:26:23 UTC (rev 215685)
@@ -45,6 +45,7 @@
*/
@interface WebHTMLRepresentation : NSObject <WebDocumentRepresentation, WebDocumentDOM>
{
+@private
WebHTMLRepresentationPrivate *_private;
}
Modified: trunk/Source/WebKit/mac/WebView/WebNotification.h (215684 => 215685)
--- trunk/Source/WebKit/mac/WebView/WebNotification.h 2017-04-24 17:21:00 UTC (rev 215684)
+++ trunk/Source/WebKit/mac/WebView/WebNotification.h 2017-04-24 17:26:23 UTC (rev 215685)
@@ -33,6 +33,7 @@
@interface WebNotification : NSObject
{
+@private
WebNotificationPrivate *_private;
}
