Title: [99515] trunk/Source/WebCore
- Revision
- 99515
- Author
- [email protected]
- Date
- 2011-11-07 18:41:53 -0800 (Mon, 07 Nov 2011)
Log Message
Remove [CustomGetter] IDL for window.Image of V8
https://bugs.webkit.org/show_bug.cgi?id=71739
Reviewed by Adam Barth.
Currently, window.Image uses a custom getter to get the template
of 'HTMLImageElementConstructor'. However, this getter does not need to
be custom and can use a default getter
'DOMWindowInternal::DOMWindowConstructorGetter'.
Tests: fast/js/custom-constructors.html
fast/dom/image-object.html
fast/dom/gc-image-element.html
fast/dom/Window/custom-constructors.html
* bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
* page/DOMWindow.idl: Removed [CustomGetter] IDL from window.Image of V8. Renamed 'HTMLImageElementConstructor' to 'HTMLImageElementConstructorConstructor' in order to make window.Image use the template of (not 'HTMLImageElement' but) 'HTMLImageElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from the IDL type.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (99514 => 99515)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 02:25:59 UTC (rev 99514)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 02:41:53 UTC (rev 99515)
@@ -1,3 +1,23 @@
+2011-11-07 Kentaro Hara <[email protected]>
+
+ Remove [CustomGetter] IDL for window.Image of V8
+ https://bugs.webkit.org/show_bug.cgi?id=71739
+
+ Reviewed by Adam Barth.
+
+ Currently, window.Image uses a custom getter to get the template
+ of 'HTMLImageElementConstructor'. However, this getter does not need to
+ be custom and can use a default getter
+ 'DOMWindowInternal::DOMWindowConstructorGetter'.
+
+ Tests: fast/js/custom-constructors.html
+ fast/dom/image-object.html
+ fast/dom/gc-image-element.html
+ fast/dom/Window/custom-constructors.html
+
+ * bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
+ * page/DOMWindow.idl: Removed [CustomGetter] IDL from window.Image of V8. Renamed 'HTMLImageElementConstructor' to 'HTMLImageElementConstructorConstructor' in order to make window.Image use the template of (not 'HTMLImageElement' but) 'HTMLImageElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from the IDL type.
+
2011-11-07 Chris Fleizach <[email protected]>
REGRESSION(r99025-r99037): platform/mac/accessibility/select-element-selection-with-optgroups.html is asserting
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp (99514 => 99515)
--- trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp 2011-11-08 02:25:59 UTC (rev 99514)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp 2011-11-08 02:41:53 UTC (rev 99515)
@@ -57,7 +57,6 @@
#include "V8GCForContextDispose.h"
#include "V8HiddenPropertyName.h"
#include "V8HTMLCollection.h"
-#include "V8HTMLImageElementConstructor.h"
#include "V8MessagePortCustom.h"
#include "V8Node.h"
#include "V8Proxy.h"
@@ -225,12 +224,6 @@
info.This()->Set(name, value);
}
-v8::Handle<v8::Value> V8DOMWindow::ImageAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
-{
- DOMWindow* window = V8DOMWindow::toNative(info.Holder());
- return V8DOMWrapper::getConstructor(&V8HTMLImageElementConstructor::info, window);
-}
-
v8::Handle<v8::Value> V8DOMWindow::addEventListenerCallback(const v8::Arguments& args)
{
INC_STATS("DOM.DOMWindow.addEventListener()");
Modified: trunk/Source/WebCore/page/DOMWindow.idl (99514 => 99515)
--- trunk/Source/WebCore/page/DOMWindow.idl 2011-11-08 02:25:59 UTC (rev 99514)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2011-11-08 02:41:53 UTC (rev 99515)
@@ -490,7 +490,7 @@
attribute HTMLAllCollectionConstructor HTMLAllCollection;
attribute HTMLUnknownElementConstructor HTMLUnknownElement;
- attribute [CustomGetter] HTMLImageElementConstructor Image; // Usable with new operator
+ attribute [JSCCustomGetter] HTMLImageElementConstructorConstructor Image; // Usable with new operator
attribute [JSCCustomGetter] HTMLOptionElementConstructorConstructor Option; // Usable with new operator
attribute CanvasPatternConstructor CanvasPattern;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
