Title: [216014] trunk/Source/WTF
Revision
216014
Author
[email protected]
Date
2017-05-01 09:11:24 -0700 (Mon, 01 May 2017)

Log Message

Cleanup: Change ASCIICaseInsensitiveHash from a class to a struct
https://bugs.webkit.org/show_bug.cgi?id=171460

Reviewed by Sam Weinig.

All of the members of ASCIICaseInsensitiveHash have public visibility.
We are underutilizing the purpose of a class - defaults to private
visibility of members. We should change ASCIICaseInsensitiveHash from
a class to a struct, which by definition defaults to public visibility
for members.

* wtf/text/StringHash.h:

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (216013 => 216014)


--- trunk/Source/WTF/ChangeLog	2017-05-01 13:10:14 UTC (rev 216013)
+++ trunk/Source/WTF/ChangeLog	2017-05-01 16:11:24 UTC (rev 216014)
@@ -1,3 +1,18 @@
+2017-05-01  Daniel Bates  <[email protected]>
+
+        Cleanup: Change ASCIICaseInsensitiveHash from a class to a struct
+        https://bugs.webkit.org/show_bug.cgi?id=171460
+
+        Reviewed by Sam Weinig.
+
+        All of the members of ASCIICaseInsensitiveHash have public visibility.
+        We are underutilizing the purpose of a class - defaults to private
+        visibility of members. We should change ASCIICaseInsensitiveHash from
+        a class to a struct, which by definition defaults to public visibility
+        for members.
+
+        * wtf/text/StringHash.h:
+
 2017-04-29  Yusuke Suzuki  <[email protected]>
 
         Move WebCore CPUTime to WTF and implement it in all the platforms

Modified: trunk/Source/WTF/wtf/text/StringHash.h (216013 => 216014)


--- trunk/Source/WTF/wtf/text/StringHash.h	2017-05-01 13:10:14 UTC (rev 216013)
+++ trunk/Source/WTF/wtf/text/StringHash.h	2017-05-01 16:11:24 UTC (rev 216014)
@@ -79,8 +79,7 @@
         static const bool safeToCompareToEmptyOrDeleted = false;
     };
 
-    class ASCIICaseInsensitiveHash {
-    public:
+    struct ASCIICaseInsensitiveHash {
         template<typename T> static inline UChar foldCase(T character)
         {
             return toASCIILower(character);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to