Diff
Modified: trunk/ChangeLog (216029 => 216030)
--- trunk/ChangeLog 2017-05-01 21:38:38 UTC (rev 216029)
+++ trunk/ChangeLog 2017-05-01 21:49:28 UTC (rev 216030)
@@ -1,3 +1,23 @@
+2017-05-01 Aakash Jain <[email protected]>
+
+ fix check-webkit-style errors in webkitpy about two blank lines before class definitions
+ https://bugs.webkit.org/show_bug.cgi?id=171509
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Scripts/webkitpy/common/config/committers.py: Added two blank lines before class definition.
+ * Scripts/webkitpy/layout_tests/models/test_run_results.py: Ditto.
+ * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Ditto.
+ * Scripts/webkitpy/port/base_unittest.py: Ditto.
+ * Scripts/webkitpy/port/device.py: Ditto.
+ * Scripts/webkitpy/port/linux_get_crash_log.py: Ditto.
+ * Scripts/webkitpy/style/checkers/featuredefines.py: Ditto.
+ * Scripts/webkitpy/style/checkers/jsonchecker.py: Ditto.
+ * Scripts/webkitpy/tool/bot/patchanalysistask.py: Ditto.
+ * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Ditto.
+ (ManagerTest.test_uses_custom_device.MockCustomDevicePort): Added blank line before method.
+ (ManagerTest.test_uses_custom_device): Removed extra blank line at end of file.
+
2017-04-25 Daniel Bates <[email protected]>
[Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (216029 => 216030)
--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2017-05-01 21:38:38 UTC (rev 216029)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2017-05-01 21:49:28 UTC (rev 216030)
@@ -37,6 +37,7 @@
from webkitpy.common.memoized import memoized
from webkitpy.common.system.filesystem import FileSystem
+
class Contributor(object):
def __init__(self, name, email_or_emails, irc_nickname_or_nicknames=None, alias_or_aliases=None, expertise=None):
assert(name)
@@ -171,6 +172,7 @@
Contributor.__init__(self, name, email_or_emails, irc_nickname, alias_or_aliases, expertise)
self.is_bot = True
+
class CommitterList(object):
# Committers and reviewers are passed in to allow easy testing
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py (216029 => 216030)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py 2017-05-01 21:38:38 UTC (rev 216029)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py 2017-05-01 21:49:28 UTC (rev 216030)
@@ -104,7 +104,8 @@
def test_uses_custom_device(self):
class MockCustomDevicePort(TestPort):
- CUSTOM_DEVICE_CLASSES = ['starship']
+ CUSTOM_DEVICE_CLASSES = ['starship']
+
def __init__(self, host):
super(MockCustomDevicePort, self).__init__(host)
@@ -116,4 +117,3 @@
manager = get_manager()
self.assertTrue(manager._custom_device_for_test('fast/test-starship/lasers.html') == 'starship')
-
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py (216029 => 216030)
--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py 2017-05-01 21:38:38 UTC (rev 216029)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py 2017-05-01 21:49:28 UTC (rev 216030)
@@ -120,6 +120,7 @@
self.keyboard_interrupted |= test_run_results.keyboard_interrupted
return self
+
class RunDetails(object):
def __init__(self, exit_code, summarized_results=None, initial_results=None, retry_results=None, enabled_pixel_tests_in_retry=False):
self.exit_code = exit_code
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (216029 => 216030)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2017-05-01 21:38:38 UTC (rev 216029)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2017-05-01 21:49:28 UTC (rev 216030)
@@ -365,6 +365,7 @@
printer.cleanup()
return -1
+
def _set_up_derived_options(port, options):
"""Sets the options values that depend on other options values."""
if not options.child_processes:
Modified: trunk/Tools/Scripts/webkitpy/port/base_unittest.py (216029 => 216030)
--- trunk/Tools/Scripts/webkitpy/port/base_unittest.py 2017-05-01 21:38:38 UTC (rev 216029)
+++ trunk/Tools/Scripts/webkitpy/port/base_unittest.py 2017-05-01 21:49:28 UTC (rev 216030)
@@ -405,6 +405,7 @@
self.assertTrue(port._filesystem.isdir(jhbuild_path))
self.assertTrue(port._should_use_jhbuild())
+
class NaturalCompareTest(unittest.TestCase):
def setUp(self):
self._port = TestPort(MockSystemHost())
Modified: trunk/Tools/Scripts/webkitpy/port/device.py (216029 => 216030)
--- trunk/Tools/Scripts/webkitpy/port/device.py 2017-05-01 21:38:38 UTC (rev 216029)
+++ trunk/Tools/Scripts/webkitpy/port/device.py 2017-05-01 21:49:28 UTC (rev 216030)
@@ -22,6 +22,7 @@
import socket
+
class Device(object):
def __init__(self, platform_device):
self.platform_device = platform_device
Modified: trunk/Tools/Scripts/webkitpy/port/linux_get_crash_log.py (216029 => 216030)
--- trunk/Tools/Scripts/webkitpy/port/linux_get_crash_log.py 2017-05-01 21:38:38 UTC (rev 216029)
+++ trunk/Tools/Scripts/webkitpy/port/linux_get_crash_log.py 2017-05-01 21:49:28 UTC (rev 216030)
@@ -30,6 +30,7 @@
import subprocess
import os
+
class GDBCrashLogGenerator(object):
def __init__(self, name, pid, newer_than, filesystem, path_to_driver):
self.name = name
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/featuredefines.py (216029 => 216030)
--- trunk/Tools/Scripts/webkitpy/style/checkers/featuredefines.py 2017-05-01 21:38:38 UTC (rev 216029)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/featuredefines.py 2017-05-01 21:49:28 UTC (rev 216030)
@@ -37,6 +37,7 @@
"Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig",
]
+
class FeatureDefinesChecker(object):
categories = set(['featuredefines/new', 'featuredefines/equality'])
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py (216029 => 216030)
--- trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py 2017-05-01 21:38:38 UTC (rev 216029)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py 2017-05-01 21:49:28 UTC (rev 216030)
@@ -26,6 +26,7 @@
import re
from sets import Set
+
class JSONChecker(object):
"""Processes JSON lines for checking style."""
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py (216029 => 216030)
--- trunk/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py 2017-05-01 21:38:38 UTC (rev 216029)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py 2017-05-01 21:49:28 UTC (rev 216030)
@@ -50,6 +50,7 @@
Exception.__init__(self)
self.patch = patch
+
class PatchAnalysisTaskDelegate(object):
def parent_command(self):
raise NotImplementedError("subclasses must implement")