Title: [216055] trunk/Source/WebKit2
Revision
216055
Author
[email protected]
Date
2017-05-01 18:47:41 -0700 (Mon, 01 May 2017)

Log Message

Use RELEASE_LOG_ERROR() to do process termination logging
https://bugs.webkit.org/show_bug.cgi?id=171521

Reviewed by Andreas Kling.

Use RELEASE_LOG_ERROR() to do process termination logging instead of RELEASE_LOG().
This makes the issue more visible in Console.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didExceedActiveMemoryLimit):
(WebKit::WebProcessProxy::didExceedInactiveMemoryLimit):
(WebKit::WebProcessProxy::didExceedBackgroundCPULimit):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (216054 => 216055)


--- trunk/Source/WebKit2/ChangeLog	2017-05-02 01:33:37 UTC (rev 216054)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-02 01:47:41 UTC (rev 216055)
@@ -1,3 +1,18 @@
+2017-05-01  Chris Dumez  <[email protected]>
+
+        Use RELEASE_LOG_ERROR() to do process termination logging
+        https://bugs.webkit.org/show_bug.cgi?id=171521
+
+        Reviewed by Andreas Kling.
+
+        Use RELEASE_LOG_ERROR() to do process termination logging instead of RELEASE_LOG().
+        This makes the issue more visible in Console.
+
+        * UIProcess/WebProcessProxy.cpp:
+        (WebKit::WebProcessProxy::didExceedActiveMemoryLimit):
+        (WebKit::WebProcessProxy::didExceedInactiveMemoryLimit):
+        (WebKit::WebProcessProxy::didExceedBackgroundCPULimit):
+
 2017-05-01  Brady Eidson  <[email protected]>
 
         Only try to get sandbox extension handle for IndexedDB directory if it is set.

Modified: trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp (216054 => 216055)


--- trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp	2017-05-02 01:33:37 UTC (rev 216054)
+++ trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp	2017-05-02 01:47:41 UTC (rev 216055)
@@ -1154,13 +1154,13 @@
 
 void WebProcessProxy::didExceedActiveMemoryLimit()
 {
-    RELEASE_LOG(PerformanceLogging, "%p - WebProcessProxy::didExceedActiveMemoryLimit() Terminating WebProcess that has exceeded the active memory limit", this);
+    RELEASE_LOG_ERROR(PerformanceLogging, "%p - WebProcessProxy::didExceedActiveMemoryLimit() Terminating WebProcess that has exceeded the active memory limit", this);
     simulateProcessCrash(SimulatedCrashReason::ExceededActiveMemoryLimit);
 }
 
 void WebProcessProxy::didExceedInactiveMemoryLimit()
 {
-    RELEASE_LOG(PerformanceLogging, "%p - WebProcessProxy::didExceedInactiveMemoryLimit() Terminating WebProcess that has exceeded the inactive memory limit", this);
+    RELEASE_LOG_ERROR(PerformanceLogging, "%p - WebProcessProxy::didExceedInactiveMemoryLimit() Terminating WebProcess that has exceeded the inactive memory limit", this);
     simulateProcessCrash(SimulatedCrashReason::ExceededInactiveMemoryLimit);
 }
 
@@ -1181,7 +1181,7 @@
         }
     }
 
-    RELEASE_LOG(PerformanceLogging, "%p - WebProcessProxy::didExceedBackgroundCPULimit() Terminating background WebProcess that has exceeded the background CPU limit", this);
+    RELEASE_LOG_ERROR(PerformanceLogging, "%p - WebProcessProxy::didExceedBackgroundCPULimit() Terminating background WebProcess that has exceeded the background CPU limit", this);
     simulateProcessCrash(SimulatedCrashReason::ExceededBackgroundCPULimit);
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to