Title: [216091] trunk/Tools
- Revision
- 216091
- Author
- [email protected]
- Date
- 2017-05-02 13:28:50 -0700 (Tue, 02 May 2017)
Log Message
Rolling out jstest_unittest.py so it can be reviewed
Follow-up fix for:
check-webkit-style should keep _javascript_ test functions in sync
<https://webkit.org/b/171424>
* Scripts/webkitpy/style/checkers/jstest_unittest.py: Remove.
Modified Paths
Removed Paths
Diff
Modified: trunk/Tools/ChangeLog (216090 => 216091)
--- trunk/Tools/ChangeLog 2017-05-02 20:10:12 UTC (rev 216090)
+++ trunk/Tools/ChangeLog 2017-05-02 20:28:50 UTC (rev 216091)
@@ -1,8 +1,18 @@
2017-05-02 David Kilzer <[email protected]>
+ Rolling out jstest_unittest.py so it can be reviewed
+
+ Follow-up fix for:
check-webkit-style should keep _javascript_ test functions in sync
<https://webkit.org/b/171424>
+ * Scripts/webkitpy/style/checkers/jstest_unittest.py: Remove.
+
+2017-05-02 David Kilzer <[email protected]>
+
+ check-webkit-style should keep _javascript_ test functions in sync
+ <https://webkit.org/b/171424>
+
Reviewed by Joseph Pecoraro.
Add a new JSTestChecker for check-webkit-style that keeps these
Deleted: trunk/Tools/Scripts/webkitpy/style/checkers/jstest_unittest.py (216090 => 216091)
--- trunk/Tools/Scripts/webkitpy/style/checkers/jstest_unittest.py 2017-05-02 20:10:12 UTC (rev 216090)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/jstest_unittest.py 2017-05-02 20:28:50 UTC (rev 216091)
@@ -1,66 +0,0 @@
-# Copyright (C) 2017 Apple Inc. All rights reserved.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-# 1. Redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer.
-# 2. Redistributions in binary form must reproduce the above copyright
-# notice, this list of conditions and the following disclaimer in the
-# documentation and/or other materials provided with the distribution.
-#
-# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-"""Unit test for jstest.py."""
-
-import unittest
-
-from jstest import map_functions_to_dict
-
-
-class JSTestTestCase(unittest.TestCase):
- """TestCase for jstest.py"""
-
- def test_map_functions_to_dict(self):
- """Tests map_functions_to_dict().
-
- This also implicitly tests strip_trailing_blank_lines_and_comments().
- """
- file1 = """
-function shouldBe() {}
-
-// Same as !shouldBe(), but output makes more sense.
-function shouldNotBe() {}
-
-function shouldNotThrow() {
- return;
-}
-
-// See also shouldNotThrow().
-function shouldThrow() {
-}
-
-"""
- result1 = map_functions_to_dict(file1)
-
- file2 = """function shouldBe() {}
-function shouldNotBe() {}
-function shouldThrow() {
-}
-function shouldNotThrow() {
- return;
-}
-"""
- result2 = map_functions_to_dict(file2)
-
- self.assertDictEqual(result1, result2)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
