Title: [216095] trunk/Source/WebKit2
- Revision
- 216095
- Author
- [email protected]
- Date
- 2017-05-02 14:24:58 -0700 (Tue, 02 May 2017)
Log Message
Stop using strcpy() in WebProcess::registerWithStateDumper() in WebProcessCocoa.mm
<https://webkit.org/b/171520>
Reviewed by Chris Dumez.
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::registerWithStateDumper): Switch from
strcpy() to strlcpy(), removing comment in the process.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (216094 => 216095)
--- trunk/Source/WebKit2/ChangeLog 2017-05-02 21:13:04 UTC (rev 216094)
+++ trunk/Source/WebKit2/ChangeLog 2017-05-02 21:24:58 UTC (rev 216095)
@@ -1,3 +1,14 @@
+2017-05-02 David Kilzer <[email protected]>
+
+ Stop using strcpy() in WebProcess::registerWithStateDumper() in WebProcessCocoa.mm
+ <https://webkit.org/b/171520>
+
+ Reviewed by Chris Dumez.
+
+ * WebProcess/cocoa/WebProcessCocoa.mm:
+ (WebKit::WebProcess::registerWithStateDumper): Switch from
+ strcpy() to strlcpy(), removing comment in the process.
+
2017-05-02 Andrew Gold <[email protected]>
MediaDevices is not enabled for MobileSafari
Modified: trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm (216094 => 216095)
--- trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm 2017-05-02 21:13:04 UTC (rev 216094)
+++ trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm 2017-05-02 21:24:58 UTC (rev 216095)
@@ -283,7 +283,7 @@
memset(os_state, 0, neededSize);
os_state->osd_type = OS_STATE_DATA_SERIALIZED_NSCF_OBJECT;
os_state->osd_data_size = data.length;
- strcpy(os_state->osd_title, "WebContent state"); // NB: Only 64 bytes of buffer here.
+ strlcpy(os_state->osd_title, "WebContent state", sizeof(os_state->osd_title));
memcpy(os_state->osd_data, data.bytes, data.length);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
