Title: [216108] trunk/Tools
- Revision
- 216108
- Author
- [email protected]
- Date
- 2017-05-02 19:48:25 -0700 (Tue, 02 May 2017)
Log Message
ews should indicate in logs when it fails to fetch the attachment
https://bugs.webkit.org/show_bug.cgi?id=171583
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.fetch_attachment): Added log statement.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (216107 => 216108)
--- trunk/Tools/ChangeLog 2017-05-03 00:11:11 UTC (rev 216107)
+++ trunk/Tools/ChangeLog 2017-05-03 02:48:25 UTC (rev 216108)
@@ -1,3 +1,13 @@
+2017-05-02 Aakash Jain <[email protected]>
+
+ ews should indicate in logs when it fails to fetch the attachment
+ https://bugs.webkit.org/show_bug.cgi?id=171583
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+ (Bugzilla.fetch_attachment): Added log statement.
+
2017-05-02 David Kilzer <[email protected]>
Rolling out jstest_unittest.py so it can be reviewed
Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py (216107 => 216108)
--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py 2017-05-03 00:11:11 UTC (rev 216107)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py 2017-05-03 02:48:25 UTC (rev 216108)
@@ -513,11 +513,13 @@
# so re-use that.
bug_id = self.bug_id_for_attachment_id(attachment_id)
if not bug_id:
+ _log.warning("Unable to parse bug_id from attachment {}".format(attachment_id))
return None
attachments = self.fetch_bug(bug_id).attachments(include_obsolete=True)
for attachment in attachments:
if attachment.id() == int(attachment_id):
return attachment
+ _log.error("Error in fetching attachment {}, bug_id: {}".format(attachment_id, bug_id))
return None # This should never be hit.
def authenticate(self):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
