Title: [216176] releases/WebKitGTK/webkit-2.16/Source/WebKit2
Revision
216176
Author
carlo...@webkit.org
Date
2017-05-04 00:38:02 -0700 (Thu, 04 May 2017)

Log Message

Merge r214947 - Show a log message when an invalid message is received in non cocoa ports
https://bugs.webkit.org/show_bug.cgi?id=170506

Patch by Carlos Garcia Campos <cgar...@igalia.com> on 2017-04-05
Reviewed by Michael Catanzaro.

We just crash, but without knowing the details about the message it's impossible to debug.

* Shared/ChildProcess.cpp:
(WebKit::ChildProcess::didReceiveInvalidMessage):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.16/Source/WebKit2/ChangeLog (216175 => 216176)


--- releases/WebKitGTK/webkit-2.16/Source/WebKit2/ChangeLog	2017-05-04 06:58:49 UTC (rev 216175)
+++ releases/WebKitGTK/webkit-2.16/Source/WebKit2/ChangeLog	2017-05-04 07:38:02 UTC (rev 216176)
@@ -1,3 +1,15 @@
+2017-04-05  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        Show a log message when an invalid message is received in non cocoa ports
+        https://bugs.webkit.org/show_bug.cgi?id=170506
+
+        Reviewed by Michael Catanzaro.
+
+        We just crash, but without knowing the details about the message it's impossible to debug.
+
+        * Shared/ChildProcess.cpp:
+        (WebKit::ChildProcess::didReceiveInvalidMessage):
+
 2017-04-04  Carlos Garcia Campos  <cgar...@igalia.com>
 
         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.16.1 release.

Modified: releases/WebKitGTK/webkit-2.16/Source/WebKit2/Shared/ChildProcess.cpp (216175 => 216176)


--- releases/WebKitGTK/webkit-2.16/Source/WebKit2/Shared/ChildProcess.cpp	2017-05-04 06:58:49 UTC (rev 216175)
+++ releases/WebKitGTK/webkit-2.16/Source/WebKit2/Shared/ChildProcess.cpp	2017-05-04 07:38:02 UTC (rev 216176)
@@ -197,8 +197,9 @@
 {
 }
 
-void ChildProcess::didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference, IPC::StringReference)
+void ChildProcess::didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName)
 {
+    WTFLogAlways("Received invalid message: '%s::%s'", messageReceiverName.toString().data(), messageName.toString().data());
     CRASH();
 }
 #endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to