Title: [216200] trunk
- Revision
- 216200
- Author
- cdu...@apple.com
- Date
- 2017-05-04 12:55:05 -0700 (Thu, 04 May 2017)
Log Message
Reformat / clean up Event.idl
https://bugs.webkit.org/show_bug.cgi?id=171675
Reviewed by Sam Weinig.
Source/WebCore:
Reformat / clean up Event.idl to match the latest spec more closely:
- https://dom.spec.whatwg.org/#interface-event
There is no web-facing behavior change, except for properties being
enumerated in a slightly different order.
* dom/Event.idl:
LayoutTests:
Rebaseline test now that the Event properties are in a slightly different order.
* inspector/model/remote-object-get-properties-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (216199 => 216200)
--- trunk/LayoutTests/ChangeLog 2017-05-04 19:49:48 UTC (rev 216199)
+++ trunk/LayoutTests/ChangeLog 2017-05-04 19:55:05 UTC (rev 216200)
@@ -1,3 +1,14 @@
+2017-05-04 Chris Dumez <cdu...@apple.com>
+
+ Reformat / clean up Event.idl
+ https://bugs.webkit.org/show_bug.cgi?id=171675
+
+ Reviewed by Sam Weinig.
+
+ Rebaseline test now that the Event properties are in a slightly different order.
+
+ * inspector/model/remote-object-get-properties-expected.txt:
+
2017-05-04 Daniel Bates <daba...@apple.com>
importScripts() should respect X-Content-Type-Options: nosniff
Modified: trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt (216199 => 216200)
--- trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt 2017-05-04 19:49:48 UTC (rev 216199)
+++ trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt 2017-05-04 19:55:05 UTC (rev 216200)
@@ -235,14 +235,14 @@
target
currentTarget
eventPhase
+ cancelBubble
bubbles
cancelable
+ defaultPrevented
composed
timeStamp
- defaultPrevented
srcElement
returnValue
- cancelBubble
__proto__
ALL PROPERTIES:
@@ -252,19 +252,19 @@
target
currentTarget
eventPhase
+ cancelBubble
bubbles
cancelable
+ defaultPrevented
composed
timeStamp
- defaultPrevented
srcElement
returnValue
- cancelBubble
composedPath
stopPropagation
+ stopImmediatePropagation
preventDefault
initEvent
- stopImmediatePropagation
NONE
CAPTURING_PHASE
AT_TARGET
Modified: trunk/Source/WebCore/ChangeLog (216199 => 216200)
--- trunk/Source/WebCore/ChangeLog 2017-05-04 19:49:48 UTC (rev 216199)
+++ trunk/Source/WebCore/ChangeLog 2017-05-04 19:55:05 UTC (rev 216200)
@@ -1,3 +1,18 @@
+2017-05-04 Chris Dumez <cdu...@apple.com>
+
+ Reformat / clean up Event.idl
+ https://bugs.webkit.org/show_bug.cgi?id=171675
+
+ Reviewed by Sam Weinig.
+
+ Reformat / clean up Event.idl to match the latest spec more closely:
+ - https://dom.spec.whatwg.org/#interface-event
+
+ There is no web-facing behavior change, except for properties being
+ enumerated in a slightly different order.
+
+ * dom/Event.idl:
+
2017-05-04 Daniel Bates <daba...@apple.com>
Cleanup: Extract CachedScript::mimeTypeAllowedByNosniff() into a common function
Modified: trunk/Source/WebCore/dom/Event.idl (216199 => 216200)
--- trunk/Source/WebCore/dom/Event.idl 2017-05-04 19:49:48 UTC (rev 216199)
+++ trunk/Source/WebCore/dom/Event.idl 2017-05-04 19:55:05 UTC (rev 216200)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2006, 2007, 2009, 2011 Apple Inc. All rights reserved.
+ * Copyright (C) 2006, 2007, 2009, 2011, 2017 Apple Inc. All rights reserved.
* Copyright (C) 2006 Samuel Weinig <sam.wei...@gmail.com>
*
* This library is free software; you can redistribute it and/or
@@ -29,34 +29,33 @@
Exposed=(Window,Worker),
JSCustomHeader,
] interface Event {
- // PhaseType
+ readonly attribute DOMString type;
+ readonly attribute EventTarget? target;
+ readonly attribute EventTarget? currentTarget;
+ [EnabledAtRuntime=ShadowDOM] sequence<EventTarget> composedPath();
+
const unsigned short NONE = 0;
const unsigned short CAPTURING_PHASE = 1;
const unsigned short AT_TARGET = 2;
const unsigned short BUBBLING_PHASE = 3;
+ readonly attribute unsigned short eventPhase;
- readonly attribute DOMString type;
- readonly attribute EventTarget target;
- readonly attribute EventTarget currentTarget;
- readonly attribute unsigned short eventPhase;
+ void stopPropagation();
+ attribute boolean cancelBubble; // historical alias of .stopPropagation.
+ void stopImmediatePropagation();
+
readonly attribute boolean bubbles;
readonly attribute boolean cancelable;
- [EnabledAtRuntime=ShadowDOM] readonly attribute boolean composed;
- readonly attribute DOMTimeStamp timeStamp;
-
- [EnabledAtRuntime=ShadowDOM] sequence<Node> composedPath();
-
- void stopPropagation();
void preventDefault();
-
- void initEvent(DOMString type, optional boolean bubbles = false, optional boolean cancelable = false);
-
readonly attribute boolean defaultPrevented;
- void stopImmediatePropagation();
+ [EnabledAtRuntime=ShadowDOM] readonly attribute boolean composed;
[Unforgeable] readonly attribute boolean isTrusted;
+ readonly attribute DOMTimeStamp timeStamp;
+ void initEvent(DOMString type, optional boolean bubbles = false, optional boolean cancelable = false); // Historical.
+
+ // IE extensions that may get standardized (https://github.com/whatwg/dom/issues/334).
readonly attribute EventTarget srcElement;
[ImplementedAs=legacyReturnValue] attribute boolean returnValue;
- attribute boolean cancelBubble;
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
