Modified: trunk/Tools/ChangeLog (216234 => 216235)
--- trunk/Tools/ChangeLog 2017-05-05 05:37:54 UTC (rev 216234)
+++ trunk/Tools/ChangeLog 2017-05-05 06:37:48 UTC (rev 216235)
@@ -1,3 +1,19 @@
+2017-05-04 Brian Burg <bb...@apple.com>
+
+ lldb_webkit.py should provide a type summary for WebCore::URL
+ https://bugs.webkit.org/show_bug.cgi?id=171670
+
+ Reviewed by Jer Noble.
+
+ Just print out the underlying string using the WTFString provider.
+
+ * lldb/lldb_webkit.py:
+ (__lldb_init_module):
+ (WebCoreURL_SummaryProvider):
+ (WebCoreURLProvider):
+ (WebCoreURLProvider.__init__):
+ (WebCoreURLProvider.to_string):
+
2017-05-04 Commit Queue <commit-qu...@webkit.org>
Unreviewed, rolling out r216206.
Modified: trunk/Tools/lldb/lldb_webkit.py (216234 => 216235)
--- trunk/Tools/lldb/lldb_webkit.py 2017-05-05 05:37:54 UTC (rev 216234)
+++ trunk/Tools/lldb/lldb_webkit.py 2017-05-05 06:37:48 UTC (rev 216235)
@@ -1,4 +1,4 @@
-# Copyright (C) 2012 Apple. All rights reserved.
+# Copyright (C) 2012-2017 Apple Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
@@ -46,6 +46,7 @@
debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreLayoutUnit_SummaryProvider WebCore::LayoutUnit')
debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreLayoutSize_SummaryProvider WebCore::LayoutSize')
debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreLayoutPoint_SummaryProvider WebCore::LayoutPoint')
+ debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreURL_SummaryProvider WebCore::URL')
def WTFString_SummaryProvider(valobj, dict):
provider = WTFStringProvider(valobj, dict)
@@ -88,6 +89,11 @@
return "{ %d/%d, %f }" % (provider.timeValue(), provider.timeScale(), float(provider.timeValue()) / provider.timeScale())
+def WebCoreURL_SummaryProvider(valobj, dict):
+ provider = WebCoreURLProvider(valobj, dict)
+ return "{ %s }" % provider.to_string()
+
+
def WebCoreLayoutUnit_SummaryProvider(valobj, dict):
provider = WebCoreLayoutUnitProvider(valobj, dict)
return "{ %s }" % provider.to_string()
@@ -155,7 +161,6 @@
# FIXME: Provide support for the following types:
# def WTFVector_SummaryProvider(valobj, dict):
# def WTFCString_SummaryProvider(valobj, dict):
-# def WebCoreKURLGooglePrivate_SummaryProvider(valobj, dict):
# def WebCoreQualifiedName_SummaryProvider(valobj, dict):
# def JSCIdentifier_SummaryProvider(valobj, dict):
# def JSCJSString_SummaryProvider(valobj, dict):
@@ -304,6 +309,14 @@
return WebCoreLayoutUnitProvider(self.valobj.GetChildMemberWithName('m_y'), dict).to_string()
+class WebCoreURLProvider:
+ "Print a WebCore::URL"
+ def __init__(self, valobj, dict):
+ self.valobj = valobj
+
+ def to_string(self):
+ return WTFStringProvider(self.valobj.GetChildMemberWithName('m_string'), dict).to_string()
+
class WTFVectorProvider:
def __init__(self, valobj, internal_dict):
self.valobj = valobj
