Title: [99558] trunk/Source/WebCore
Revision
99558
Author
[email protected]
Date
2011-11-08 05:38:13 -0800 (Tue, 08 Nov 2011)

Log Message

Web Inspector: do not show object popover when selection is active
https://bugs.webkit.org/show_bug.cgi?id=71804

Reviewed by Yury Semikhatsky.

* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame.prototype._shouldShowPopover):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (99557 => 99558)


--- trunk/Source/WebCore/ChangeLog	2011-11-08 13:34:38 UTC (rev 99557)
+++ trunk/Source/WebCore/ChangeLog	2011-11-08 13:38:13 UTC (rev 99558)
@@ -1,3 +1,13 @@
+2011-11-08  Andrey Kosyakov  <[email protected]>
+
+        Web Inspector: do not show object popover when selection is active
+        https://bugs.webkit.org/show_bug.cgi?id=71804
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/_javascript_SourceFrame.js:
+        (WebInspector._javascript_SourceFrame.prototype._shouldShowPopover):
+
 2011-11-08  Alexander Pavlov  <[email protected]>
 
         Web Inspector: Do not hide SuggestBox if typed-in string in the middle of input equals one of suggestions

Modified: trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js (99557 => 99558)


--- trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js	2011-11-08 13:34:38 UTC (rev 99557)
+++ trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js	2011-11-08 13:38:13 UTC (rev 99558)
@@ -248,6 +248,8 @@
             return false;
         if (!element.enclosingNodeOrSelfWithClass("webkit-line-content"))
             return false;
+        if (window.getSelection().type === "Range")
+            return false;
 
         // We are interested in identifiers and "this" keyword.
         if (element.hasStyleClass("webkit-_javascript_-keyword"))
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to