[webkit-changes] [99566] trunk/LayoutTests

Tue, 08 Nov 2011 07:16:57 -0800

Title: [99566] trunk/LayoutTests
Revision
99566
Author
[email protected]
Date
2011-11-08 07:16:16 -0800 (Tue, 08 Nov 2011)

Log Message

2011-11-08  Nikolas Zimmermann  <[email protected]>

        [Qt] 4 new tests fail introduced in r98852
        https://bugs.webkit.org/show_bug.cgi?id=71253

        Reviewed by Rob Buis.

        Address some problems seen on Qt/Chromium:
        - Remove the scaled png which is the source of the problem in zoom-background-images.html, we really only want to test zooming in the SVGImage there.
        - Don't zoom out more than three times, otherwise its ignored on Mac/DRT, where the minimum zoom factor is clamped to 0.5f.
          Qt doesn't have this limit, and currently zooms more than Mac does. There's no need to zoom out that often, three times is enough.

        * platform/mac/svg/zoom/page/zoom-background-images-expected.png: Updated.
        * platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Update.
        * svg/zoom/page/zoom-background-image-tiled.html: Don't set shouldZoomOut to false, it's the default.
        * svg/zoom/page/zoom-background-images.html: Don't zoom out more than three times.
        * svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm: Ditto.
        * svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Ditto.
        * svg/zoom/page/zoom-svg-as-image.html: There is no shouldZoomIn, just remove it, zooming in is the default.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (99565 => 99566)


--- trunk/LayoutTests/ChangeLog	2011-11-08 14:42:25 UTC (rev 99565)
+++ trunk/LayoutTests/ChangeLog	2011-11-08 15:16:16 UTC (rev 99566)
@@ -1,3 +1,23 @@
+2011-11-08  Nikolas Zimmermann  <[email protected]>
+
+        [Qt] 4 new tests fail introduced in r98852
+        https://bugs.webkit.org/show_bug.cgi?id=71253
+
+        Reviewed by Rob Buis.
+
+        Address some problems seen on Qt/Chromium:
+        - Remove the scaled png which is the source of the problem in zoom-background-images.html, we really only want to test zooming in the SVGImage there.
+        - Don't zoom out more than three times, otherwise its ignored on Mac/DRT, where the minimum zoom factor is clamped to 0.5f.
+          Qt doesn't have this limit, and currently zooms more than Mac does. There's no need to zoom out that often, three times is enough.
+
+        * platform/mac/svg/zoom/page/zoom-background-images-expected.png: Updated.
+        * platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Update.
+        * svg/zoom/page/zoom-background-image-tiled.html: Don't set shouldZoomOut to false, it's the default.
+        * svg/zoom/page/zoom-background-images.html: Don't zoom out more than three times.
+        * svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm: Ditto.
+        * svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Ditto.
+        * svg/zoom/page/zoom-svg-as-image.html: There is no shouldZoomIn, just remove it, zooming in is the default.
+
 2011-11-08  Gavin Peters  <[email protected]>
 
         Fix width of m_type in CachedResource

Modified: trunk/LayoutTests/platform/mac/svg/zoom/page/zoom-background-images-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/mac/svg/zoom/page/zoom-background-images-expected.txt (99565 => 99566)


--- trunk/LayoutTests/platform/mac/svg/zoom/page/zoom-background-images-expected.txt	2011-11-08 14:42:25 UTC (rev 99565)
+++ trunk/LayoutTests/platform/mac/svg/zoom/page/zoom-background-images-expected.txt	2011-11-08 15:16:16 UTC (rev 99566)
@@ -13,9 +13,6 @@
       RenderText {#text} at (457,143) size 2x10
         text run at (457,143) width 2: " "
       RenderImage {IMG} at (470,11) size 129x129 [border: (1px solid #000000)]
-      RenderText {#text} at (610,143) size 2x10
-        text run at (610,143) width 2: " "
-      RenderImage {IMG} at (623,11) size 129x129 [border: (1px solid #000000)]
       RenderText {#text} at (0,0) size 0x0
       RenderText {#text} at (0,0) size 0x0
       RenderText {#text} at (0,0) size 0x0

Modified: trunk/LayoutTests/svg/zoom/page/zoom-background-image-tiled.html (99565 => 99566)


--- trunk/LayoutTests/svg/zoom/page/zoom-background-image-tiled.html	2011-11-08 14:42:25 UTC (rev 99565)
+++ trunk/LayoutTests/svg/zoom/page/zoom-background-image-tiled.html	2011-11-08 15:16:16 UTC (rev 99566)
@@ -17,7 +17,7 @@
 <body>
 <div></div>
 
-<script>var zoomCount = 4; window.shouldZoomOut = false;</script>
+<script>var zoomCount = 4;</script>
 <script src=""
 
 </body>

Modified: trunk/LayoutTests/svg/zoom/page/zoom-background-images.html (99565 => 99566)


--- trunk/LayoutTests/svg/zoom/page/zoom-background-images.html	2011-11-08 14:42:25 UTC (rev 99565)
+++ trunk/LayoutTests/svg/zoom/page/zoom-background-images.html	2011-11-08 15:16:16 UTC (rev 99566)
@@ -31,9 +31,8 @@
 <div class="svg"></div>
 <div class="gradient"></div>
 <img src=""
-<img src=""
 
-<script>var zoomCount = 5; window.shouldZoomOut = true;</script>
+<script>var zoomCount = 3; window.shouldZoomOut = true;</script>
 <script src=""
 
 </body>

Modified: trunk/LayoutTests/svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm (99565 => 99566)


--- trunk/LayoutTests/svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm	2011-11-08 14:42:25 UTC (rev 99565)
+++ trunk/LayoutTests/svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm	2011-11-08 15:16:16 UTC (rev 99566)
@@ -40,7 +40,7 @@
   <table id="t5"><tr><td><object id="img5" type="image/svg+xml" data="" test won't work because you do not have images enabled.</object></td></tr></table>
   <p id="p3"><object id="img3" type="image/svg+xml" data="" test won't work because you do not have images enabled.</object></p>
 
-  <script>var zoomCount = 4; window.shouldZoomOut = true;</script>
+  <script>var zoomCount = 3; window.shouldZoomOut = true;</script>
   <script src=""
  </body>
 </html>

Modified: trunk/LayoutTests/svg/zoom/page/zoom-svg-as-background-with-relative-size.html (99565 => 99566)


--- trunk/LayoutTests/svg/zoom/page/zoom-svg-as-background-with-relative-size.html	2011-11-08 14:42:25 UTC (rev 99565)
+++ trunk/LayoutTests/svg/zoom/page/zoom-svg-as-background-with-relative-size.html	2011-11-08 15:16:16 UTC (rev 99566)
@@ -14,7 +14,7 @@
 <body style='margin: 0px'>
 <div>&nbsp;</div>
 
-<script>var zoomCount = 4; window.shouldZoomOut = true;</script>
+<script>var zoomCount = 3; window.shouldZoomOut = true;</script>
 <script src=""
 </body>
 </html>

Modified: trunk/LayoutTests/svg/zoom/page/zoom-svg-as-image.html (99565 => 99566)


--- trunk/LayoutTests/svg/zoom/page/zoom-svg-as-image.html	2011-11-08 14:42:25 UTC (rev 99565)
+++ trunk/LayoutTests/svg/zoom/page/zoom-svg-as-image.html	2011-11-08 15:16:16 UTC (rev 99566)
@@ -13,7 +13,7 @@
   <img src=''>
 </div>
 
-<script>var zoomCount = 4; window.shouldZoomIn = true;</script>
+<script>var zoomCount = 4;</script>
 <script src=""
 
 </body>

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to