Title: [216495] releases/WebKitGTK/webkit-2.14
Revision
216495
Author
carlo...@webkit.org
Date
2017-05-09 03:21:28 -0700 (Tue, 09 May 2017)

Log Message

Merge r216139 - YouTube user agent quirk breaks new YouTube
https://bugs.webkit.org/show_bug.cgi?id=171603

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Our user agent quirk to make YouTube 360 work breaks the new YouTube UI, causing it to
attempt to use the obsolete custom elements v0 API. WebKit only supports the v1 API. We
have to remove this quirk.

Note this does not affect Safari as Apple ports don't use our user agent quirks.

* platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresChromeBrowser):

Tools:

Remove the YouTube quirk test.

* TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/ChangeLog (216494 => 216495)


--- releases/WebKitGTK/webkit-2.14/Source/WebCore/ChangeLog	2017-05-09 10:11:46 UTC (rev 216494)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/ChangeLog	2017-05-09 10:21:28 UTC (rev 216495)
@@ -1,3 +1,19 @@
+2017-05-03  Michael Catanzaro  <mcatanz...@igalia.com>
+
+        YouTube user agent quirk breaks new YouTube
+        https://bugs.webkit.org/show_bug.cgi?id=171603
+
+        Reviewed by Carlos Garcia Campos.
+
+        Our user agent quirk to make YouTube 360 work breaks the new YouTube UI, causing it to
+        attempt to use the obsolete custom elements v0 API. WebKit only supports the v1 API. We
+        have to remove this quirk.
+
+        Note this does not affect Safari as Apple ports don't use our user agent quirks.
+
+        * platform/UserAgentQuirks.cpp:
+        (WebCore::urlRequiresChromeBrowser):
+
 2017-04-21  Gwang Yoon Hwang  <y...@igalia.com>
 
         Do not paint the border of the box if the dirty region does not intersect with border area

Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/platform/gtk/UserAgentGtk.cpp (216494 => 216495)


--- releases/WebKitGTK/webkit-2.14/Source/WebCore/platform/gtk/UserAgentGtk.cpp	2017-05-09 10:11:46 UTC (rev 216494)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/platform/gtk/UserAgentGtk.cpp	2017-05-09 10:21:28 UTC (rev 216495)
@@ -212,10 +212,6 @@
     if (baseDomain == "typekit.net" || baseDomain == "typekit.com")
         return true;
 
-    // Needed for YouTube 360 (requires ENABLE_MEDIA_SOURCE).
-    if (baseDomain == "youtube.com")
-        return true;
-
     // Slack completely blocks users with our standard user agent.
     if (baseDomain == "slack.com")
         return true;

Modified: releases/WebKitGTK/webkit-2.14/Tools/ChangeLog (216494 => 216495)


--- releases/WebKitGTK/webkit-2.14/Tools/ChangeLog	2017-05-09 10:11:46 UTC (rev 216494)
+++ releases/WebKitGTK/webkit-2.14/Tools/ChangeLog	2017-05-09 10:21:28 UTC (rev 216495)
@@ -1,3 +1,15 @@
+2017-05-03  Michael Catanzaro  <mcatanz...@igalia.com>
+
+        YouTube user agent quirk breaks new YouTube
+        https://bugs.webkit.org/show_bug.cgi?id=171603
+
+        Reviewed by Carlos Garcia Campos.
+
+        Remove the YouTube quirk test.
+
+        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
+        (TestWebKitAPI::TEST):
+
 2017-01-26  Chris Dumez  <cdu...@apple.com>
 
         Crash when navigating back to a page in PacheCache when one of its frames has been removed
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to