Title: [216506] trunk/Source/WebCore
- Revision
- 216506
- Author
- [email protected]
- Date
- 2017-05-09 08:04:12 -0700 (Tue, 09 May 2017)
Log Message
Update DocumentOrShadowRoot.idl to match specifications
https://bugs.webkit.org/show_bug.cgi?id=171845
Reviewed by Ryosuke Niwa.
Update DocumentOrShadowRoot.idl to match specifications:
- https://dom.spec.whatwg.org/#mixin-documentorshadowroot
- https://w3c.github.io/webcomponents/spec/shadow/#extensions-to-the-documentorshadowroot-mixin
- https://w3c.github.io/pointerlock/#extensions-to-the-documentorshadowroot-mixin
No Web-facing behavior change. Things that do not match the specification were merely
annotated with FIXME comments.
* dom/Document.idl:
* dom/DocumentOrShadowRoot.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (216505 => 216506)
--- trunk/Source/WebCore/ChangeLog 2017-05-09 14:53:01 UTC (rev 216505)
+++ trunk/Source/WebCore/ChangeLog 2017-05-09 15:04:12 UTC (rev 216506)
@@ -1,3 +1,21 @@
+2017-05-09 Chris Dumez <[email protected]>
+
+ Update DocumentOrShadowRoot.idl to match specifications
+ https://bugs.webkit.org/show_bug.cgi?id=171845
+
+ Reviewed by Ryosuke Niwa.
+
+ Update DocumentOrShadowRoot.idl to match specifications:
+ - https://dom.spec.whatwg.org/#mixin-documentorshadowroot
+ - https://w3c.github.io/webcomponents/spec/shadow/#extensions-to-the-documentorshadowroot-mixin
+ - https://w3c.github.io/pointerlock/#extensions-to-the-documentorshadowroot-mixin
+
+ No Web-facing behavior change. Things that do not match the specification were merely
+ annotated with FIXME comments.
+
+ * dom/Document.idl:
+ * dom/DocumentOrShadowRoot.idl:
+
2017-05-09 Yusuke Suzuki <[email protected]>
Unreviewed, attempt to fix macOS ports using ApplePay
Modified: trunk/Source/WebCore/dom/Document.idl (216505 => 216506)
--- trunk/Source/WebCore/dom/Document.idl 2017-05-09 14:53:01 UTC (rev 216505)
+++ trunk/Source/WebCore/dom/Document.idl 2017-05-09 15:04:12 UTC (rev 216506)
@@ -103,14 +103,14 @@
[LenientThis] attribute EventHandler onreadystatechange;
// Extensions from the CSSOM specification (https://drafts.csswg.org/cssom/#extensions-to-the-document-interface).
+ // FIXME: Should likely be moved to DocumentOrShadowRoot.
readonly attribute StyleSheetList styleSheets; // FIXME: Should be [SameObject].
// Extensions from the CSSOM-View specification (https://drafts.csswg.org/cssom-view/#extensions-to-the-document-interface).
readonly attribute Element? scrollingElement;
- // sequence<Element> elementsFromPoint(double x, double y); // FIXME: Implement this.
- // CaretPosition? caretPositionFromPoint(double x, double y); // FIXME: Implement this.
// Extensions from Selection API (https://www.w3.org/TR/selection-api/#extensions-to-document-interface).
+ // FIXME: Should likely be moved to DocumentOrShadowRoot.
DOMSelection? getSelection();
// XPath extensions (https://www.w3.org/TR/DOM-Level-3-XPath/xpath.html#XPathEvaluator).
@@ -133,7 +133,6 @@
// Extensions from Pointer Lock API (https://www.w3.org/TR/pointerlock/#extensions-to-the-document-interface).
[NotEnumerable, Conditional=POINTER_LOCK] attribute EventHandler onpointerlockchange; // FIXME: Should be enumerable.
[NotEnumerable, Conditional=POINTER_LOCK] attribute EventHandler onpointerlockerror; // FIXME: Should be enumerable.
- // readonly attribute Element? pointerLockElement; // FIXME: Implement this.
[Conditional=POINTER_LOCK] void exitPointerLock();
// Extensions from CSS Font Loading API (https://drafts.csswg.org/css-font-loading/#font-face-source).
Modified: trunk/Source/WebCore/dom/DocumentOrShadowRoot.idl (216505 => 216506)
--- trunk/Source/WebCore/dom/DocumentOrShadowRoot.idl 2017-05-09 14:53:01 UTC (rev 216505)
+++ trunk/Source/WebCore/dom/DocumentOrShadowRoot.idl 2017-05-09 15:04:12 UTC (rev 216506)
@@ -25,11 +25,17 @@
*/
// https://dom.spec.whatwg.org/#documentorshadowroot
-// https://www.w3.org/TR/shadow-dom/#extensions-to-the-documentorshadowroot-mixin
[
NoInterfaceObject,
] interface DocumentOrShadowRoot {
+ // Extensions from Shadow DOM API (https://w3c.github.io/webcomponents/spec/shadow/#extensions-to-the-documentorshadowroot-mixin).
+ // DOMSelection? getSelection(); // FIXME: We currently have this on Document only.
Element? elementFromPoint(double x, double y);
+ // sequence<Element> elementsFromPoint(double x, double y); // FIXME: Implement this.
+ // CaretPosition? caretPositionFromPoint(double x, double y); // FIXME: Implement this.
readonly attribute Element? activeElement;
+ // readonly attribute StyleSheetList styleSheets; // FIXME: Implement this.
+
+ // Extensions from Pointer Lock API (https://w3c.github.io/pointerlock/#extensions-to-the-documentorshadowroot-mixin).
[Conditional=POINTER_LOCK] readonly attribute Element? pointerLockElement;
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes