Title: [216544] trunk/Source/WebCore
Revision
216544
Author
[email protected]
Date
2017-05-09 14:52:53 -0700 (Tue, 09 May 2017)

Log Message

[Modern Media Controls] Localized strings aren't loaded
https://bugs.webkit.org/show_bug.cgi?id=171884

Patch by Antoine Quint <[email protected]> on 2017-05-09
Reviewed by Dean Jackson.

Remove the extraneous file extension in the file name.

* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::mediaControlsScript):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::mediaControlsScript):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (216543 => 216544)


--- trunk/Source/WebCore/ChangeLog	2017-05-09 21:49:27 UTC (rev 216543)
+++ trunk/Source/WebCore/ChangeLog	2017-05-09 21:52:53 UTC (rev 216544)
@@ -1,3 +1,17 @@
+2017-05-09  Antoine Quint  <[email protected]>
+
+        [Modern Media Controls] Localized strings aren't loaded
+        https://bugs.webkit.org/show_bug.cgi?id=171884
+
+        Reviewed by Dean Jackson.
+
+        Remove the extraneous file extension in the file name.
+
+        * rendering/RenderThemeIOS.mm:
+        (WebCore::RenderThemeIOS::mediaControlsScript):
+        * rendering/RenderThemeMac.mm:
+        (WebCore::RenderThemeMac::mediaControlsScript):
+
 2017-05-09  Chris Dumez  <[email protected]>
 
         Introduce DocumentAndElementEventHandlers IDL interface

Modified: trunk/Source/WebCore/rendering/RenderThemeIOS.mm (216543 => 216544)


--- trunk/Source/WebCore/rendering/RenderThemeIOS.mm	2017-05-09 21:49:27 UTC (rev 216543)
+++ trunk/Source/WebCore/rendering/RenderThemeIOS.mm	2017-05-09 21:52:53 UTC (rev 216544)
@@ -1349,7 +1349,7 @@
             NSBundle *bundle = [NSBundle bundleForClass:[WebCoreRenderThemeBundle class]];
 
             StringBuilder scriptBuilder;
-            scriptBuilder.append([NSString stringWithContentsOfFile:[bundle pathForResource:@"modern-media-controls-localized-strings.js" ofType:@"js"] encoding:NSUTF8StringEncoding error:nil]);
+            scriptBuilder.append([NSString stringWithContentsOfFile:[bundle pathForResource:@"modern-media-controls-localized-strings" ofType:@"js"] encoding:NSUTF8StringEncoding error:nil]);
             scriptBuilder.append([NSString stringWithContentsOfFile:[bundle pathForResource:@"modern-media-controls" ofType:@"js" inDirectory:@"modern-media-controls"] encoding:NSUTF8StringEncoding error:nil]);
             m_mediaControlsScript = scriptBuilder.toString();
         }

Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (216543 => 216544)


--- trunk/Source/WebCore/rendering/RenderThemeMac.mm	2017-05-09 21:49:27 UTC (rev 216543)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm	2017-05-09 21:52:53 UTC (rev 216544)
@@ -270,7 +270,7 @@
             NSBundle *bundle = [NSBundle bundleForClass:[WebCoreRenderThemeBundle class]];
 
             StringBuilder scriptBuilder;
-            scriptBuilder.append([NSString stringWithContentsOfFile:[bundle pathForResource:@"modern-media-controls-localized-strings.js" ofType:@"js"] encoding:NSUTF8StringEncoding error:nil]);
+            scriptBuilder.append([NSString stringWithContentsOfFile:[bundle pathForResource:@"modern-media-controls-localized-strings" ofType:@"js"] encoding:NSUTF8StringEncoding error:nil]);
             scriptBuilder.append([NSString stringWithContentsOfFile:[bundle pathForResource:@"modern-media-controls" ofType:@"js" inDirectory:@"modern-media-controls"] encoding:NSUTF8StringEncoding error:nil]);
             m_mediaControlsScript = scriptBuilder.toString();
         }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to