Title: [99596] trunk/Source/WebCore
Revision
99596
Author
[email protected]
Date
2011-11-08 11:13:22 -0800 (Tue, 08 Nov 2011)

Log Message

Remove get() defined in CredentialStorageSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=71825

Reviewed by Martin Robinson.

CredentialStorage::get() is implemented in CredentialStorage.cpp. And CredentialStorage.cpp
provides the base implementation for each platform. We shouldn't re-define
CredentialStorage::get() in CredentialStorageSoup.cpp.

* GNUmakefile.list.am: Add source file CredentialStorage.cpp.
* platform/network/soup/CredentialStorageSoup.cpp: Remove re-definition of CredentialStorage::get().
CredentialStorage::get() is defined in CredentialStorage.cpp.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (99595 => 99596)


--- trunk/Source/WebCore/ChangeLog	2011-11-08 19:04:43 UTC (rev 99595)
+++ trunk/Source/WebCore/ChangeLog	2011-11-08 19:13:22 UTC (rev 99596)
@@ -1,3 +1,18 @@
+2011-11-08  Daniel Bates  <[email protected]>
+
+        Remove get() defined in CredentialStorageSoup.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=71825
+
+        Reviewed by Martin Robinson.
+
+        CredentialStorage::get() is implemented in CredentialStorage.cpp. And CredentialStorage.cpp
+        provides the base implementation for each platform. We shouldn't re-define
+        CredentialStorage::get() in CredentialStorageSoup.cpp.
+
+        * GNUmakefile.list.am: Add source file CredentialStorage.cpp.
+        * platform/network/soup/CredentialStorageSoup.cpp: Remove re-definition of CredentialStorage::get().
+        CredentialStorage::get() is defined in CredentialStorage.cpp.
+
 2011-11-08  Roland Steiner  <[email protected]>
 
         Rename CSS document() -> findDocument(), to indicate tree climbing

Modified: trunk/Source/WebCore/GNUmakefile.list.am (99595 => 99596)


--- trunk/Source/WebCore/GNUmakefile.list.am	2011-11-08 19:04:43 UTC (rev 99595)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2011-11-08 19:13:22 UTC (rev 99596)
@@ -2789,6 +2789,7 @@
 	Source/WebCore/platform/network/CookieStorage.h \
 	Source/WebCore/platform/network/Credential.cpp \
 	Source/WebCore/platform/network/Credential.h \
+	Source/WebCore/platform/network/CredentialStorage.cpp \
 	Source/WebCore/platform/network/CredentialStorage.h \
 	Source/WebCore/platform/network/DNS.h \
 	Source/WebCore/platform/network/FormDataBuilder.cpp \

Modified: trunk/Source/WebCore/platform/network/soup/CredentialStorageSoup.cpp (99595 => 99596)


--- trunk/Source/WebCore/platform/network/soup/CredentialStorageSoup.cpp	2011-11-08 19:04:43 UTC (rev 99595)
+++ trunk/Source/WebCore/platform/network/soup/CredentialStorageSoup.cpp	2011-11-08 19:13:22 UTC (rev 99596)
@@ -35,9 +35,4 @@
     return Credential();
 }
 
-Credential CredentialStorage::get(const ProtectionSpace&)
-{
-    return Credential();
-}
-
 } // namespace WebCore
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to