Title: [217036] trunk/Source/WebKit2
- Revision
- 217036
- Author
- [email protected]
- Date
- 2017-05-17 23:02:05 -0700 (Wed, 17 May 2017)
Log Message
Fix unsafe lambda capture in ContentRuleListStore::lookupContentRuleList()
https://bugs.webkit.org/show_bug.cgi?id=172258
Reviewed by Brady Eidson.
Fix unsafe lambda capture in ContentRuleListStore::lookupContentRuleList(). The String
was moved instead of calling isolatedCopy(), even though we're passing the String to
another thread.
* UIProcess/API/APIContentRuleListStore.cpp:
(API::ContentRuleListStore::lookupContentRuleList):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (217035 => 217036)
--- trunk/Source/WebKit2/ChangeLog 2017-05-18 05:36:01 UTC (rev 217035)
+++ trunk/Source/WebKit2/ChangeLog 2017-05-18 06:02:05 UTC (rev 217036)
@@ -1,3 +1,17 @@
+2017-05-17 Chris Dumez <[email protected]>
+
+ Fix unsafe lambda capture in ContentRuleListStore::lookupContentRuleList()
+ https://bugs.webkit.org/show_bug.cgi?id=172258
+
+ Reviewed by Brady Eidson.
+
+ Fix unsafe lambda capture in ContentRuleListStore::lookupContentRuleList(). The String
+ was moved instead of calling isolatedCopy(), even though we're passing the String to
+ another thread.
+
+ * UIProcess/API/APIContentRuleListStore.cpp:
+ (API::ContentRuleListStore::lookupContentRuleList):
+
2017-05-16 Yusuke Suzuki <[email protected]>
[JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
Modified: trunk/Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp (217035 => 217036)
--- trunk/Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp 2017-05-18 05:36:01 UTC (rev 217035)
+++ trunk/Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp 2017-05-18 06:02:05 UTC (rev 217036)
@@ -401,7 +401,7 @@
return;
}
- RunLoop::main().dispatch([protectedThis = WTFMove(protectedThis), identifier = WTFMove(identifier), fileData = WTFMove(fileData), metaData = WTFMove(metaData), completionHandler = WTFMove(completionHandler)] {
+ RunLoop::main().dispatch([protectedThis = WTFMove(protectedThis), identifier = identifier.isolatedCopy(), fileData = WTFMove(fileData), metaData = WTFMove(metaData), completionHandler = WTFMove(completionHandler)] {
completionHandler(createExtension(identifier, metaData, fileData), { });
});
});
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
