Title: [217040] branches/safari-604.1.21-branch/Tools
- Revision
- 217040
- Author
- [email protected]
- Date
- 2017-05-18 01:14:15 -0700 (Thu, 18 May 2017)
Log Message
Cherry-pick r217010. rdar://problem/32141505
Modified Paths
Diff
Modified: branches/safari-604.1.21-branch/Tools/ChangeLog (217039 => 217040)
--- branches/safari-604.1.21-branch/Tools/ChangeLog 2017-05-18 08:05:03 UTC (rev 217039)
+++ branches/safari-604.1.21-branch/Tools/ChangeLog 2017-05-18 08:14:15 UTC (rev 217040)
@@ -1,5 +1,20 @@
2017-05-17 Jason Marcell <[email protected]>
+ Cherry-pick r217010. rdar://problem/32141505
+
+ 2017-05-17 Alex Christensen <[email protected]>
+
+ Fix ios-simulator API test after r216977
+ https://bugs.webkit.org/show_bug.cgi?id=171987
+
+ * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
+ (TEST):
+ <rdar://problem/32260156> covers the investigation of this, but fixing it is
+ not as urgent as having the rest of this working. Notably the ephemeral part of the
+ test works, so something is just wrong with the persistent part.
+
+2017-05-17 Jason Marcell <[email protected]>
+
Cherry-pick r216977. rdar://problem/32141505
2017-05-17 Alex Christensen <[email protected]>
Modified: branches/safari-604.1.21-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm (217039 => 217040)
--- branches/safari-604.1.21-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm 2017-05-18 08:05:03 UTC (rev 217039)
+++ branches/safari-604.1.21-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm 2017-05-18 08:14:15 UTC (rev 217040)
@@ -203,6 +203,8 @@
}];
TestWebKitAPI::Util::run(&finished);
+ // FIXME: Investigate why this doesn't work on iOS with the default persistent storage. rdar://problem/32260156
+#if !PLATFORM(IOS)
finished = false;
WKWebsiteDataStore *defaultStore = [WKWebsiteDataStore defaultDataStore];
[defaultStore.httpCookieStore setCookie:cookie completionHandler:^ {
@@ -226,5 +228,6 @@
}];
}];
TestWebKitAPI::Util::run(&finished);
+#endif
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
