Title: [217053] trunk/Tools
- Revision
- 217053
- Author
- [email protected]
- Date
- 2017-05-18 11:26:29 -0700 (Thu, 18 May 2017)
Log Message
[Win] Many layout tests are failing.
https://bugs.webkit.org/show_bug.cgi?id=172286
Reviewed by Brent Fulgham.
Add a FIXME comment about unimplemented functions, instead of writing this to the test result file.
* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::grantWebNotificationPermission):
(TestRunner::denyWebNotificationPermission):
(TestRunner::removeAllWebNotificationPermissions):
(TestRunner::simulateWebNotificationClick):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (217052 => 217053)
--- trunk/Tools/ChangeLog 2017-05-18 18:22:19 UTC (rev 217052)
+++ trunk/Tools/ChangeLog 2017-05-18 18:26:29 UTC (rev 217053)
@@ -1,3 +1,18 @@
+2017-05-18 Per Arne Vollan <[email protected]>
+
+ [Win] Many layout tests are failing.
+ https://bugs.webkit.org/show_bug.cgi?id=172286
+
+ Reviewed by Brent Fulgham.
+
+ Add a FIXME comment about unimplemented functions, instead of writing this to the test result file.
+
+ * DumpRenderTree/win/TestRunnerWin.cpp:
+ (TestRunner::grantWebNotificationPermission):
+ (TestRunner::denyWebNotificationPermission):
+ (TestRunner::removeAllWebNotificationPermissions):
+ (TestRunner::simulateWebNotificationClick):
+
2017-05-18 Don Olmstead <[email protected]>
[Win] Remove usage of _snprintf
Modified: trunk/Tools/DumpRenderTree/win/TestRunnerWin.cpp (217052 => 217053)
--- trunk/Tools/DumpRenderTree/win/TestRunnerWin.cpp 2017-05-18 18:22:19 UTC (rev 217052)
+++ trunk/Tools/DumpRenderTree/win/TestRunnerWin.cpp 2017-05-18 18:26:29 UTC (rev 217053)
@@ -1368,22 +1368,26 @@
void TestRunner::grantWebNotificationPermission(JSStringRef origin)
{
- fprintf(testResult, "ERROR: TestRunner::grantWebNotificationPermission(JSStringRef) not implemented\n");
+ // FIXME: Implement.
+ // See https://bugs.webkit.org/show_bug.cgi?id=172295
}
void TestRunner::denyWebNotificationPermission(JSStringRef jsOrigin)
{
- fprintf(testResult, "ERROR: TestRunner::denyWebNotificationPermission(JSStringRef) not implemented\n");
+ // FIXME: Implement.
+ // See https://bugs.webkit.org/show_bug.cgi?id=172295
}
void TestRunner::removeAllWebNotificationPermissions()
{
- fprintf(testResult, "ERROR: TestRunner::removeAllWebNotificationPermissions() not implemented\n");
+ // FIXME: Implement.
+ // See https://bugs.webkit.org/show_bug.cgi?id=172295
}
void TestRunner::simulateWebNotificationClick(JSValueRef jsNotification)
{
- fprintf(testResult, "ERROR: TestRunner::simulateWebNotificationClick() not implemented\n");
+ // FIXME: Implement.
+ // See https://bugs.webkit.org/show_bug.cgi?id=172295
}
void TestRunner::simulateLegacyWebNotificationClick(JSStringRef title)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
