Title: [217056] trunk/Source/WebCore
- Revision
- 217056
- Author
- [email protected]
- Date
- 2017-05-18 11:56:32 -0700 (Thu, 18 May 2017)
Log Message
Cleanup: Remove unnecessary call to AddToImplIncludes("RuntimeEnabledFeatures.h") in GenerateImplementation()
https://bugs.webkit.org/show_bug.cgi?id=172236
Reviewed by Chris Dumez.
It is unnecessary for GenerateImplementation() to explicitly call AddToImplIncludes("RuntimeEnabledFeatures.h")
to add the header RuntimeEnabledFeatures.h to the list of headers in the generated implementation
as this header is added when GetRuntimeEnableFunctionName() is called. And GenerateImplementation()
calls GetRuntimeEnableFunctionName().
No functionality changed. So, no new tests.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (217055 => 217056)
--- trunk/Source/WebCore/ChangeLog 2017-05-18 18:56:15 UTC (rev 217055)
+++ trunk/Source/WebCore/ChangeLog 2017-05-18 18:56:32 UTC (rev 217056)
@@ -1,5 +1,22 @@
2017-05-18 Daniel Bates <[email protected]>
+ Cleanup: Remove unnecessary call to AddToImplIncludes("RuntimeEnabledFeatures.h") in GenerateImplementation()
+ https://bugs.webkit.org/show_bug.cgi?id=172236
+
+ Reviewed by Chris Dumez.
+
+ It is unnecessary for GenerateImplementation() to explicitly call AddToImplIncludes("RuntimeEnabledFeatures.h")
+ to add the header RuntimeEnabledFeatures.h to the list of headers in the generated implementation
+ as this header is added when GetRuntimeEnableFunctionName() is called. And GenerateImplementation()
+ calls GetRuntimeEnableFunctionName().
+
+ No functionality changed. So, no new tests.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateImplementation):
+
+2017-05-18 Daniel Bates <[email protected]>
+
REGRESSION (r209608): Cross-origin plugin document opened in child window blocked by parent
window CSP when object-src 'none' is set
https://bugs.webkit.org/show_bug.cgi?id=172038
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (217055 => 217056)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2017-05-18 18:56:15 UTC (rev 217055)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2017-05-18 18:56:32 UTC (rev 217056)
@@ -3419,7 +3419,6 @@
foreach my $functionOrAttribute (@runtimeEnabledProperties) {
my $conditionalString = $codeGenerator->GenerateConditionalString($functionOrAttribute);
push(@implContent, "#if ${conditionalString}\n") if $conditionalString;
- AddToImplIncludes("RuntimeEnabledFeatures.h");
my $enable_function_result = GetRuntimeEnableFunctionName($functionOrAttribute);
my $name = $functionOrAttribute->name;
push(@implContent, " if (!${enable_function_result}) {\n");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
