Title: [217080] trunk/Source/WebKit2
Revision
217080
Author
[email protected]
Date
2017-05-18 17:47:59 -0700 (Thu, 18 May 2017)

Log Message

Data interaction conclusion snapshot has too much margin
https://bugs.webkit.org/show_bug.cgi?id=172323
<rdar://problem/32283772>

Reviewed by Beth Dakin.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::didConcludeEditDataInteraction):
Disable the default TextIndicator margin.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (217079 => 217080)


--- trunk/Source/WebKit2/ChangeLog	2017-05-19 00:37:43 UTC (rev 217079)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-19 00:47:59 UTC (rev 217080)
@@ -1,3 +1,15 @@
+2017-05-18  Tim Horton  <[email protected]>
+
+        Data interaction conclusion snapshot has too much margin
+        https://bugs.webkit.org/show_bug.cgi?id=172323
+        <rdar://problem/32283772>
+
+        Reviewed by Beth Dakin.
+
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::WebPage::didConcludeEditDataInteraction):
+        Disable the default TextIndicator margin.
+
 2017-05-18  Andy Estes  <[email protected]>
 
         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier

Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (217079 => 217080)


--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm	2017-05-19 00:37:43 UTC (rev 217079)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm	2017-05-19 00:47:59 UTC (rev 217080)
@@ -635,7 +635,7 @@
     static auto defaultEditDataInteractionTextIndicatorOptions = TextIndicatorOptionIncludeSnapshotOfAllVisibleContentWithoutSelection | TextIndicatorOptionDoNotClipToVisibleRect | TextIndicatorOptionPaintAllContent | TextIndicatorOptionIncludeMarginIfRangeMatchesSelection | TextIndicatorOptionPaintBackgrounds | TextIndicatorOptionComputeEstimatedBackgroundColor| TextIndicatorOptionUseSelectionRectForSizing | TextIndicatorOptionIncludeSnapshotWithSelectionHighlight;
     auto& frame = m_page->focusController().focusedOrMainFrame();
     if (auto range = frame.selection().selection().toNormalizedRange()) {
-        if (auto textIndicator = TextIndicator::createWithRange(*range, defaultEditDataInteractionTextIndicatorOptions, TextIndicatorPresentationTransition::None))
+        if (auto textIndicator = TextIndicator::createWithRange(*range, defaultEditDataInteractionTextIndicatorOptions, TextIndicatorPresentationTransition::None, FloatSize()))
             textIndicatorData = textIndicator->data();
     }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to