Title: [217459] trunk/Source/_javascript_Core
- Revision
- 217459
- Author
- [email protected]
- Date
- 2017-05-25 17:18:25 -0700 (Thu, 25 May 2017)
Log Message
Cleanup tests after r217240
https://bugs.webkit.org/show_bug.cgi?id=172466
Reviewed by Mark Lam.
I forgot to make my test an actual test. Also, remove second call runJSExportTests()
* API/tests/JSExportTests.mm:
(wrapperForNSObjectisObject):
* API/tests/testapi.mm:
(testObjectiveCAPIMain):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/tests/JSExportTests.mm (217458 => 217459)
--- trunk/Source/_javascript_Core/API/tests/JSExportTests.mm 2017-05-26 00:06:44 UTC (rev 217458)
+++ trunk/Source/_javascript_Core/API/tests/JSExportTests.mm 2017-05-26 00:18:25 UTC (rev 217459)
@@ -161,7 +161,7 @@
context.exception = nil;
context[@"A"] = NSObject.class;
- NSLog(@"here: %@", [context exception]);
+ checkResult(@"Should not throw an exception when wrapping NSObject and Object has been changed", [context exception]);
}
}
Modified: trunk/Source/_javascript_Core/API/tests/testapi.mm (217458 => 217459)
--- trunk/Source/_javascript_Core/API/tests/testapi.mm 2017-05-26 00:06:44 UTC (rev 217458)
+++ trunk/Source/_javascript_Core/API/tests/testapi.mm 2017-05-26 00:18:25 UTC (rev 217459)
@@ -512,8 +512,6 @@
static void testObjectiveCAPIMain()
{
- runJSExportTests();
-
@autoreleasepool {
JSVirtualMachine* vm = [[JSVirtualMachine alloc] init];
JSContext* context = [[JSContext alloc] initWithVirtualMachine:vm];
Modified: trunk/Source/_javascript_Core/ChangeLog (217458 => 217459)
--- trunk/Source/_javascript_Core/ChangeLog 2017-05-26 00:06:44 UTC (rev 217458)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-05-26 00:18:25 UTC (rev 217459)
@@ -1,3 +1,17 @@
+2017-05-25 Keith Miller <[email protected]>
+
+ Cleanup tests after r217240
+ https://bugs.webkit.org/show_bug.cgi?id=172466
+
+ Reviewed by Mark Lam.
+
+ I forgot to make my test an actual test. Also, remove second call runJSExportTests()
+
+ * API/tests/JSExportTests.mm:
+ (wrapperForNSObjectisObject):
+ * API/tests/testapi.mm:
+ (testObjectiveCAPIMain):
+
2017-05-25 Michael Saboff <[email protected]>
The default setting of Option::criticalGCMemoryThreshold is too high for iOS
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
