Title: [217477] trunk
- Revision
- 217477
- Author
- [email protected]
- Date
- 2017-05-25 23:46:27 -0700 (Thu, 25 May 2017)
Log Message
Don't reset m_hasDisplayContents on ElementRareData::resetComputedStyle.
https://bugs.webkit.org/show_bug.cgi?id=172503
Patch by Emilio Cobos Álvarez <[email protected]> on 2017-05-25
Reviewed by Antti Koivisto.
Source/WebCore:
We use that bit of information to determine whether we need to tear
down the renderers of a display: contents subtree, so better for it to
not change until the render tree is updated.
In practice, we may want to remove that bit and use ElementRareData's
RenderStyle instead (keeping it around as appropriate), to ensure they
don't go out of sync, but that's out of scope of this patch for now.
Tests: imported/w3c/web-platform-tests/css/css-display-3
* dom/ElementRareData.h:
(WebCore::ElementRareData::resetComputedStyle):
LayoutTests:
* TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (217476 => 217477)
--- trunk/LayoutTests/ChangeLog 2017-05-26 05:39:12 UTC (rev 217476)
+++ trunk/LayoutTests/ChangeLog 2017-05-26 06:46:27 UTC (rev 217477)
@@ -1,3 +1,12 @@
+2017-05-25 Emilio Cobos Álvarez <[email protected]>
+
+ Don't reset m_hasDisplayContents on ElementRareData::resetComputedStyle.
+ https://bugs.webkit.org/show_bug.cgi?id=172503
+
+ Reviewed by Antti Koivisto.
+
+ * TestExpectations:
+
2017-05-25 Sam Weinig <[email protected]>
Fix MediaDeviceInfo's extended attributes so they make sense
Modified: trunk/LayoutTests/TestExpectations (217476 => 217477)
--- trunk/LayoutTests/TestExpectations 2017-05-26 05:39:12 UTC (rev 217476)
+++ trunk/LayoutTests/TestExpectations 2017-05-26 06:46:27 UTC (rev 217477)
@@ -1159,7 +1159,6 @@
webkit.org/b/157477 imported/w3c/web-platform-tests/css/css-display-3/display-contents-inline-flex-001.html [ ImageOnlyFailure ]
webkit.org/b/157477 imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-before-after-first-letter-001.html [ ImageOnlyFailure ]
webkit.org/b/157477 imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-before-after-001.html [ ImageOnlyFailure ]
-webkit.org/b/157477 imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-flex-001-none.html [ ImageOnlyFailure ]
webkit.org/b/157477 imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-table-002-none.html [ ImageOnlyFailure ]
webkit.org/b/157477 imported/w3c/web-platform-tests/css/css-display-3/display-contents-flex-003.html [ ImageOnlyFailure ]
webkit.org/b/157477 imported/w3c/web-platform-tests/css/css-display-3/display-contents-alignment-001.html [ ImageOnlyFailure ]
@@ -1177,13 +1176,12 @@
webkit.org/b/157477 imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-flex-003-none.html [ ImageOnlyFailure ]
webkit.org/b/157477 imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-table-001-none.html [ ImageOnlyFailure ]
webkit.org/b/157477 imported/w3c/web-platform-tests/css/css-display-3/display-contents-state-change-001.html [ ImageOnlyFailure ]
+webkit.org/b/157477 imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-inline.html [ ImageOnlyFailure ]
+webkit.org/b/157477 imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-flex-003-inline.html [ ImageOnlyFailure ]
+webkit.org/b/157477 imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-list-001-inline.html [ ImageOnlyFailure ]
+webkit.org/b/157477 imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-list-001-none.html [ ImageOnlyFailure ]
-webkit.org/b/172503 imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-inline.html [ Skip ]
-webkit.org/b/172503 imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-flex-003-inline.html [ Skip ]
-webkit.org/b/172503 imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-list-001-inline.html [ Skip ]
-webkit.org/b/172503 imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-list-001-none.html [ Skip ]
-webkit.org/b/172503 imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-multicol-001-inline.html [ Skip ]
-webkit.org/b/172503 imported/w3c/web-platform-tests/css/css-display-3/display-contents-replaced-001.html [ Skip ]
+webkit.org/b/172596 imported/w3c/web-platform-tests/css/css-display-3/display-contents-replaced-001.html [ Skip ]
### END OF display: contents failures
########################################
@@ -1374,5 +1372,3 @@
webkit.org/b/172378 imported/blink/fast/block/float/float-mark-descendants-for-layout-crash.html [ Skip ]
webkit.org/b/172378 imported/blink/fast/frames/freed-frame.html [ Skip ]
webkit.org/b/172378 imported/blink/printing/print-document-without-documentElement-crash.html [ Skip ]
-
-webkit.org/b/172514 imported/w3c/web-platform-tests/innerText/getter.html [ Skip ]
Modified: trunk/Source/WebCore/ChangeLog (217476 => 217477)
--- trunk/Source/WebCore/ChangeLog 2017-05-26 05:39:12 UTC (rev 217476)
+++ trunk/Source/WebCore/ChangeLog 2017-05-26 06:46:27 UTC (rev 217477)
@@ -1,3 +1,23 @@
+2017-05-25 Emilio Cobos Álvarez <[email protected]>
+
+ Don't reset m_hasDisplayContents on ElementRareData::resetComputedStyle.
+ https://bugs.webkit.org/show_bug.cgi?id=172503
+
+ Reviewed by Antti Koivisto.
+
+ We use that bit of information to determine whether we need to tear
+ down the renderers of a display: contents subtree, so better for it to
+ not change until the render tree is updated.
+
+ In practice, we may want to remove that bit and use ElementRareData's
+ RenderStyle instead (keeping it around as appropriate), to ensure they
+ don't go out of sync, but that's out of scope of this patch for now.
+
+ Tests: imported/w3c/web-platform-tests/css/css-display-3
+
+ * dom/ElementRareData.h:
+ (WebCore::ElementRareData::resetComputedStyle):
+
2017-05-25 Sam Weinig <[email protected]>
Fix MediaDeviceInfo's extended attributes so they make sense
Modified: trunk/Source/WebCore/dom/ElementRareData.h (217476 => 217477)
--- trunk/Source/WebCore/dom/ElementRareData.h 2017-05-26 05:39:12 UTC (rev 217476)
+++ trunk/Source/WebCore/dom/ElementRareData.h 2017-05-26 06:46:27 UTC (rev 217477)
@@ -214,7 +214,6 @@
inline void ElementRareData::resetComputedStyle()
{
m_computedStyle = nullptr;
- m_hasDisplayContents = false;
}
inline void ElementRareData::resetStyleRelations()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
