Title: [217505] trunk/Source/WebInspectorUI
Revision
217505
Author
[email protected]
Date
2017-05-26 14:14:31 -0700 (Fri, 26 May 2017)

Log Message

Web Inspector: Reloading the page after switching from the Resource tab switches back
https://bugs.webkit.org/show_bug.cgi?id=172622

Reviewed by Joseph Pecoraro.

* UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel.prototype._treeSelectionDidChange):
* UserInterface/Views/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype._treeSelectionDidChange):
* UserInterface/Views/SearchSidebarPanel.js:
(WebInspector.SearchSidebarPanel.prototype._treeSelectionDidChange):
Don't show the newly selected tree element's represented object if the sidebar is not visible.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (217504 => 217505)


--- trunk/Source/WebInspectorUI/ChangeLog	2017-05-26 20:59:30 UTC (rev 217504)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-05-26 21:14:31 UTC (rev 217505)
@@ -1,5 +1,20 @@
 2017-05-26  Devin Rousso  <[email protected]>
 
+        Web Inspector: Reloading the page after switching from the Resource tab switches back
+        https://bugs.webkit.org/show_bug.cgi?id=172622
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/DebuggerSidebarPanel.js:
+        (WebInspector.DebuggerSidebarPanel.prototype._treeSelectionDidChange):
+        * UserInterface/Views/ResourceSidebarPanel.js:
+        (WebInspector.ResourceSidebarPanel.prototype._treeSelectionDidChange):
+        * UserInterface/Views/SearchSidebarPanel.js:
+        (WebInspector.SearchSidebarPanel.prototype._treeSelectionDidChange):
+        Don't show the newly selected tree element's represented object if the sidebar is not visible.
+
+2017-05-26  Devin Rousso  <[email protected]>
+
         Web Inspector: New Tab contents have extra vertical spacing when wrapped
         https://bugs.webkit.org/show_bug.cgi?id=172530
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (217504 => 217505)


--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js	2017-05-26 20:59:30 UTC (rev 217504)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js	2017-05-26 21:14:31 UTC (rev 217505)
@@ -823,6 +823,9 @@
 
     _treeSelectionDidChange(event)
     {
+        if (!this.visible)
+            return;
+
         let treeElement = event.data.selectedElement;
         if (!treeElement)
             return;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js (217504 => 217505)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js	2017-05-26 20:59:30 UTC (rev 217504)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js	2017-05-26 21:14:31 UTC (rev 217505)
@@ -429,6 +429,9 @@
 
     _treeSelectionDidChange(event)
     {
+        if (!this.visible)
+            return;
+
         let treeElement = event.data.selectedElement;
         if (!treeElement)
             return;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js (217504 => 217505)


--- trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js	2017-05-26 20:59:30 UTC (rev 217504)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js	2017-05-26 21:14:31 UTC (rev 217505)
@@ -351,6 +351,9 @@
 
     _treeSelectionDidChange(event)
     {
+        if (!this.visible)
+            return;
+
         let treeElement = event.data.selectedElement;
         if (!treeElement || treeElement instanceof WebInspector.FolderTreeElement)
             return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to