Title: [217517] trunk/Source/_javascript_Core
- Revision
- 217517
- Author
- [email protected]
- Date
- 2017-05-26 19:33:09 -0700 (Fri, 26 May 2017)
Log Message
REEGRESSION(r217459): testapi fails in JSExportTest's wrapperForNSObjectisObject().
https://bugs.webkit.org/show_bug.cgi?id=172654
Reviewed by Mark Lam.
The test's intent is to assert that an exception has not been
thrown (as indicated by the message string), but the test was
erroneously checking for ! the right condition. This is now fixed.
* API/tests/JSExportTests.mm:
(wrapperForNSObjectisObject):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/tests/JSExportTests.mm (217516 => 217517)
--- trunk/Source/_javascript_Core/API/tests/JSExportTests.mm 2017-05-27 01:32:26 UTC (rev 217516)
+++ trunk/Source/_javascript_Core/API/tests/JSExportTests.mm 2017-05-27 02:33:09 UTC (rev 217517)
@@ -161,8 +161,7 @@
context.exception = nil;
context[@"A"] = NSObject.class;
- // FIXME: https://bugs.webkit.org/show_bug.cgi?id=172654
- // checkResult(@"Should not throw an exception when wrapping NSObject and Object has been changed", [context exception]);
+ checkResult(@"Should not throw an exception when wrapping NSObject and Object has been changed", ![context exception]);
}
}
Modified: trunk/Source/_javascript_Core/ChangeLog (217516 => 217517)
--- trunk/Source/_javascript_Core/ChangeLog 2017-05-27 01:32:26 UTC (rev 217516)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-05-27 02:33:09 UTC (rev 217517)
@@ -1,3 +1,17 @@
+2017-05-26 Keith Miller <[email protected]>
+
+ REEGRESSION(r217459): testapi fails in JSExportTest's wrapperForNSObjectisObject().
+ https://bugs.webkit.org/show_bug.cgi?id=172654
+
+ Reviewed by Mark Lam.
+
+ The test's intent is to assert that an exception has not been
+ thrown (as indicated by the message string), but the test was
+ erroneously checking for ! the right condition. This is now fixed.
+
+ * API/tests/JSExportTests.mm:
+ (wrapperForNSObjectisObject):
+
2017-05-26 Joseph Pecoraro <[email protected]>
JSContext Inspector: Improve the reliability of automatically pausing in auto-attach
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
